Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/lambda_layer_version: Add lambda_layer_version resource #6782

Closed
wants to merge 2 commits into from
Closed

r/lambda_layer_version: Add lambda_layer_version resource #6782

wants to merge 2 commits into from

Conversation

acburdine
Copy link
Contributor

@acburdine acburdine commented Dec 10, 2018 •
edited
Loading

refs #6651

Changes proposed in this pull request:

  • Add aws_lambda_layer resource

TODO:

  • add docs for resource
  • finish adding remainder of tests

Output from acceptance testing (so far):

$ make testacc TESTARGS='-run=TestAccAWSLambdaLayer'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run TestAccAWSLambdaLayer -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSLambdaLayer_basic
=== PAUSE TestAccAWSLambdaLayer_basic
=== RUN   TestAccAWSLambdaLayer_s3
=== PAUSE TestAccAWSLambdaLayer_s3
=== CONT  TestAccAWSLambdaLayer_basic
=== CONT  TestAccAWSLambdaLayer_s3
--- PASS: TestAccAWSLambdaLayer_basic (17.40s)
--- PASS: TestAccAWSLambdaLayer_s3 (25.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	36.018s

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 10, 2018
@namliz namliz mentioned this pull request Dec 13, 2018
Closed
@bbernays
Copy link

Is there anything we can help with to expedite this getting merged?

@acburdine
Copy link
Contributor Author

I’ve got most of the doc page finished locally, will finish it up and push tomorrow morning.

@bflad I would definitely appreciate an initial review of this though - the code itself should be finished.

@bflad bflad added the new-resource Introduces a new resource. label Dec 19, 2018
bflad
bflad reviewed Dec 19, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @acburdine 👋 Looking pretty good! Left my initial feedback below. Please reach out with any questions or if you do not have time to implement these items.

aws/provider.go Outdated Show resolved Hide resolved
aws/resource_aws_lambda_layer.go Outdated Show resolved Hide resolved
aws/resource_aws_lambda_layer.go Outdated Show resolved Hide resolved
aws/resource_aws_lambda_layer.go Outdated Show resolved Hide resolved
aws/resource_aws_lambda_layer.go Outdated Show resolved Hide resolved
aws/resource_aws_lambda_layer_test.go Outdated Show resolved Hide resolved
aws/resource_aws_lambda_layer.go Outdated Show resolved Hide resolved
aws/resource_aws_lambda_layer.go Outdated Show resolved Hide resolved
aws/resource_aws_lambda_layer.go Outdated Show resolved Hide resolved
aws/resource_aws_lambda_layer.go Outdated Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Dec 19, 2018
@bflad
Copy link
Contributor

bflad commented Jan 9, 2019

@acburdine will you have time to continue working on this pull request?

@acburdine
Copy link
Contributor Author

@bflad yup! sorry for not getting it done sooner, should be able to finish it up tomorrow/Friday.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jan 9, 2019
@acburdine
Copy link
Contributor Author

just need to finish adding some more tests and pushing the documentation, then it should be good to go

@nvdbleek
Copy link

@acburdine is there an ETA of the release that will have your PR?

@ghost ghost added the documentation Introduces or discusses updates to documentation. label Jan 12, 2019
@acburdine acburdine changed the title [wip] r/lambda_layer: Add lambda_layer resource r/lambda_layer: Add lambda_layer resource Jan 12, 2019
@acburdine
Copy link
Contributor Author

acburdine commented Jan 12, 2019 •
edited
Loading

Output from tests:

--- PASS: TestAccAWSLambdaLayerVersion_basic (12.89s)
--- PASS: TestAccAWSLambdaLayerVersion_licenseInfo (22.83s)
--- PASS: TestAccAWSLambdaLayerVersion_s3 (23.35s)
--- PASS: TestAccAWSLambdaLayerVersion_compatibleRuntimes (28.18s)
--- PASS: TestAccAWSLambdaLayerVersion_description (32.55s)
--- PASS: TestAccAWSLambdaLayerVersion_update (35.23s)

@bflad apologies for taking so long to get this finished up, let me know if I need to do anything else!

@acburdine acburdine force-pushed the r/lambda_layers branch 2 times, most recently from 8189f85 to aab51e3 Compare January 12, 2019 15:00
@acburdine acburdine changed the title r/lambda_layer: Add lambda_layer resource r/lambda_layer_version: Add lambda_layer_version resource Jan 12, 2019
@acburdine acburdine mentioned this pull request Jan 12, 2019
Merged
1 task
@bflad bflad added this to the v1.56.0 milestone Jan 15, 2019
bflad
bflad approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @acburdine! 🚀 Will make the one-line testing fix on merge so we can get this released.

Output from acceptance testing (with CheckDestroy fix):

--- PASS: TestAccAWSLambdaLayerVersion_licenseInfo (19.92s)
--- PASS: TestAccAWSLambdaLayerVersion_description (24.69s)
--- PASS: TestAccAWSLambdaLayerVersion_compatibleRuntimes (27.27s)
--- PASS: TestAccAWSLambdaLayerVersion_basic (32.73s)
--- PASS: TestAccAWSLambdaLayerVersion_s3 (34.29s)
--- PASS: TestAccAWSLambdaLayerVersion_update (34.99s)

aws/resource_aws_lambda_layer_version_test.go Outdated Show resolved Hide resolved
@bflad @acburdine
Update aws/resource_aws_lambda_layer_version_test.go
68b7605 
Co-Authored-By: acburdine <acburdine@gmail.com>
@bflad
Copy link
Contributor

bflad commented Jan 15, 2019

This is merged in as of 1069ec3

@bflad bflad closed this Jan 15, 2019
@acburdine acburdine deleted the r/lambda_layers branch January 15, 2019 12:51
bflad added a commit that referenced this pull request Jan 15, 2019
@bflad
Update CHANGELOG for #6782
2e9fe3f
@bflad
Copy link
Contributor

bflad commented Jan 16, 2019

This has been released in version 1.56.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@nvdbleek
Copy link

Thanks, it worked perfectly!

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/lambda Issues and PRs that pertain to the lambda service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.56.0
Development

Successfully merging this pull request may close these issues.
4 participants
@acburdine @bbernays @bflad @nvdbleek