lambda_function: add layers support to resource and data source #7126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/S
acburdine
force-pushed
the
r/lambda_function_layers
branch
from
106bcbd
to
aabc87a
Compare
|
@bflad working on tests for this now, should have them done today |
acburdine
force-pushed
the
r/lambda_function_layers
branch
from
aabc87a
to
6dd0e58
Compare
ghost
added
size/L
acburdine
force-pushed
the
r/lambda_function_layers
branch
from
6dd0e58
to
04520ce
Compare
acburdine
changed the title
|
Resource tests: Data source tests: |
bflad
added
the
enhancement
|
@acburdine awesome! Taking a look now. 😄 |
bflad
reviewed
Jan 15, 2019
refs hashicorp#6651 - add layers attribute to resource and data source - update documentation
acburdine
force-pushed
the
r/lambda_function_layers
branch
from
04520ce
to
afa1b5f
Compare
bflad
approved these changes
Jan 15, 2019
There was a problem hiding this comment.
Great work, @acburdine! 🎉
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (17.16s)
--- PASS: TestAccAWSLambdaFunction_importLocalFile_VPC (20.78s)
--- PASS: TestAccDataSourceAWSLambdaFunction_layers (21.06s)
--- PASS: TestAccAWSLambdaFunction_basic (31.09s)
--- PASS: TestAccDataSourceAWSLambdaFunction_version (39.05s)
--- PASS: TestAccDataSourceAWSLambdaFunction_vpc (39.57s)
--- PASS: TestAccAWSLambdaFunction_importS3 (43.00s)
--- PASS: TestAccDataSourceAWSLambdaFunction_alias (47.44s)
--- PASS: TestAccDataSourceAWSLambdaFunction_basic (52.78s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (53.07s)
--- PASS: TestAccAWSLambdaFunction_importLocalFile (53.89s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (61.99s)
--- PASS: TestAccDataSourceAWSLambdaFunction_environment (62.70s)
--- PASS: TestAccAWSLambdaFunction_versioned (64.74s)
--- PASS: TestAccAWSLambdaFunction_Layers (45.34s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_noRuntime (0.58s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (67.35s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (70.71s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (32.53s)
--- PASS: TestAccAWSLambdaFunction_VPC (41.56s)
--- PASS: TestAccAWSLambdaFunction_s3 (27.63s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (60.59s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (39.97s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python27 (28.78s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (96.40s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_java8 (29.87s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (59.50s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs810 (36.61s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (41.64s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (42.93s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (56.79s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python37 (29.69s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_provided (30.79s)
--- PASS: TestAccAWSLambdaFunction_envVariables (112.27s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (48.32s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python36 (32.50s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (98.75s)
--- PASS: TestAccAWSLambdaFunction_tags (43.98s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_ruby25 (26.83s)
--- PASS: TestAccAWSLambdaFunction_concurrency (127.71s)
--- PASS: TestAccAWSLambdaFunction_updateRuntime (129.60s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (91.37s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (136.74s)
bflad
added a commit
that referenced
this pull request
Jan 15, 2019
bflad
added a commit
that referenced
this pull request
Jan 15, 2019
|
This has been released in version 1.56.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #6651 (depends on #6782)
TODO:
Changes proposed in this pull request:
layersattribute to r/lambda_function and d/lambda_functionOutput from acceptance testing: (waiting on aforementioned PR)