-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/aws_dx_private_virtual_interface: Adding new data source for Direct Connect private virtual interfaces #7042
base: main
Are you sure you want to change the base?
d/aws_dx_private_virtual_interface: Adding new data source for Direct Connect private virtual interfaces #7042
Conversation
… Connect private virtual interfaces
I don't have an active Direct Connection ID to test against at the moment. If someone has one they can test with, please feel free to give this shot. |
Type: schema.TypeBool, | ||
Computed: true, | ||
}, | ||
"tags": tagsSchema(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to tagsSchemaComputed
.
@slapula The Travis build is failing due to
All the attributes bar |
@ewbankkit Oops, I meant to clean that stuff up! That should be fixed now with my latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @slapula 👋 Thanks for submitting this. A few minor things then we can get this in.
Please note: the maintainers cannot actually perform DirectConnect acceptance testing so this will require two passing community acceptance testing runs after these updates.
Once @bflad's comments have been addressed I will be able to test this. |
@ewbankkit I believe this should be ready to test now |
@slapula Acceptance tests: $ DX_CONNECTION_ID=dxcon-xxxxxxxx make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsDxPrivateVirtualInterface_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccDataSourceAwsDxPrivateVirtualInterface_basic -timeout 120m
=== RUN TestAccDataSourceAwsDxPrivateVirtualInterface_basic
=== PAUSE TestAccDataSourceAwsDxPrivateVirtualInterface_basic
=== CONT TestAccDataSourceAwsDxPrivateVirtualInterface_basic
--- FAIL: TestAccDataSourceAwsDxPrivateVirtualInterface_basic (588.41s)
testing.go:538: Step 0 error: Check failed: Check 5/14 error: data.aws_dx_private_virtual_interface.foo: Attribute 'bvlan' not found
FAIL
FAIL github.com/terraform-providers/terraform-provider-aws/aws 602.052s
make: *** [testacc] Error 1 |
Success 😄: $ DX_CONNECTION_ID=dxcon-xxxxxxxx make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsDxPrivateVirtualInterface_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccDataSourceAwsDxPrivateVirtualInterface_basic -timeout 120m
=== RUN TestAccDataSourceAwsDxPrivateVirtualInterface_basic
=== PAUSE TestAccDataSourceAwsDxPrivateVirtualInterface_basic
=== CONT TestAccDataSourceAwsDxPrivateVirtualInterface_basic
--- PASS: TestAccDataSourceAwsDxPrivateVirtualInterface_basic (739.29s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 752.897s |
@ewbankkit Done! |
@slapula Do you have cycles to address these merge conflicts? Thanks. |
@ewbankkit this PR should be all ready to go now |
@slapula OK, I'll give it a test soon. Thanks. |
Re-ran acceptance tests: $ DX_CONNECTION_ID=dxcon-xxxxxxxx make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsDxPrivateVirtualInterface_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccDataSourceAwsDxPrivateVirtualInterface_ -timeout 120m
=== RUN TestAccDataSourceAwsDxPrivateVirtualInterface_basic
=== PAUSE TestAccDataSourceAwsDxPrivateVirtualInterface_basic
=== CONT TestAccDataSourceAwsDxPrivateVirtualInterface_basic
--- PASS: TestAccDataSourceAwsDxPrivateVirtualInterface_basic (452.53s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 452.617s 👍 |
Getting a tag schema error here:
|
Notification of Recent and Upcoming Changes to ContributionsThank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization. If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items. For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported. Action Required: Terraform 0.12 SyntaxReference: #8950 Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations ( Action Required: Terraform Plugin SDK Version 2Reference: #14551 The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information. Action Required: Removal of website/aws.erb FileReference: #14712 Any changes to the Upcoming Change of Git Branch NamingReference: #14292 Development environments will need their upstream Git branch updated from Upcoming Change of GitHub OrganizationReference: #14715 This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including |
Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding. Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author. For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000. For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide. |
Fixes #6796
Changes proposed in this pull request:
aws_dx_private_virtual_interface
Output from acceptance testing: