d/aws_dx_private_virtual_interface: Adding new data source for Direct Connect private virtual interfaces

[slapula]

Fixes #6796

Changes proposed in this pull request:

• Adds a new data source for DX private virtual interfaces: aws_dx_private_virtual_interface

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAwsDxPrivateVirtualInterface_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccDataSourceAwsDxPrivateVirtualInterface_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccDataSourceAwsDxPrivateVirtualInterface_basic
--- SKIP: TestAccDataSourceAwsDxPrivateVirtualInterface_basic (0.00s)
    data_source_aws_dx_private_virtual_interface_test.go:17: Environment variable DX_CONNECTION_ID is not set
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	0.013s

[slapula]

I don't have an active Direct Connection ID to test against at the moment. If someone has one they can test with, please feel free to give this shot.

[ewbankkit]

Change to tagsSchemaComputed.

[ewbankkit]

@slapula The Travis build is failing due to

* data source aws_dx_private_virtual_interface: vlan: ValidateFunc is for validating user input, there's nothing to validate on computed-only field

All the attributes bar virtual_interface_id should just have Type set and Computed: true, - nothing else required.

[slapula]

@ewbankkit Oops, I meant to clean that stuff up! That should be fixed now with my latest commit.

[bflad]

Hey @slapula 👋 Thanks for submitting this. A few minor things then we can get this in.

Please note: the maintainers cannot actually perform DirectConnect acceptance testing so this will require two passing community acceptance testing runs after these updates.

[ewbankkit]

Once @bflad's comments have been addressed I will be able to test this.

[slapula]

@ewbankkit I believe this should be ready to test now

[ewbankkit]

@slapula Acceptance tests:

$ DX_CONNECTION_ID=dxcon-xxxxxxxx make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsDxPrivateVirtualInterface_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccDataSourceAwsDxPrivateVirtualInterface_basic -timeout 120m
=== RUN   TestAccDataSourceAwsDxPrivateVirtualInterface_basic
=== PAUSE TestAccDataSourceAwsDxPrivateVirtualInterface_basic
=== CONT  TestAccDataSourceAwsDxPrivateVirtualInterface_basic
--- FAIL: TestAccDataSourceAwsDxPrivateVirtualInterface_basic (588.41s)
    testing.go:538: Step 0 error: Check failed: Check 5/14 error: data.aws_dx_private_virtual_interface.foo: Attribute 'bvlan' not found
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	602.052s
make: *** [testacc] Error 1

[ewbankkit]

Success 😄:

$ DX_CONNECTION_ID=dxcon-xxxxxxxx make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsDxPrivateVirtualInterface_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccDataSourceAwsDxPrivateVirtualInterface_basic -timeout 120m
=== RUN   TestAccDataSourceAwsDxPrivateVirtualInterface_basic
=== PAUSE TestAccDataSourceAwsDxPrivateVirtualInterface_basic
=== CONT  TestAccDataSourceAwsDxPrivateVirtualInterface_basic
--- PASS: TestAccDataSourceAwsDxPrivateVirtualInterface_basic (739.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	752.897s

[ewbankkit]

@slapula Could you please add the aws_device attribute? - See #7131. Thanks.

[slapula]

@ewbankkit Done!

[ewbankkit]

@slapula Do you have cycles to address these merge conflicts? Thanks.

[slapula]

@ewbankkit this PR should be all ready to go now

[ewbankkit]

@slapula OK, I'll give it a test soon. Thanks.

[ewbankkit]

Re-ran acceptance tests:

$ DX_CONNECTION_ID=dxcon-xxxxxxxx make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsDxPrivateVirtualInterface_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccDataSourceAwsDxPrivateVirtualInterface_ -timeout 120m
=== RUN   TestAccDataSourceAwsDxPrivateVirtualInterface_basic
=== PAUSE TestAccDataSourceAwsDxPrivateVirtualInterface_basic
=== CONT  TestAccDataSourceAwsDxPrivateVirtualInterface_basic
--- PASS: TestAccDataSourceAwsDxPrivateVirtualInterface_basic (452.53s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	452.617s

👍

[devonbleak]

Getting a tag schema error here:

$ DX_CONNECTION_ID=dxcon-redacted make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsDxPrivateVirtualInterface_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccDataSourceAwsDxPrivateVirtualInterface_ -timeout 120m
# github.com/terraform-providers/terraform-provider-aws/aws [github.com/terraform-providers/terraform-provider-aws/aws.test]
aws/data_source_aws_dx_private_virtual_interface.go:76:4: cannot use tagsSchemaComputed() (type *"github.com/hashicorp/terraform-plugin-sdk/helper/schema".Schema) as type *"github.com/hashicorp/terraform/helper/schema".Schema in map value
aws/data_source_aws_dx_private_virtual_interface.go:116:19: cannot use d (type *"github.com/hashicorp/terraform/helper/schema".ResourceData) as type *"github.com/hashicorp/terraform-plugin-sdk/helper/schema".ResourceData in argument to getTagsDX
aws/provider.go:191:4: cannot use dataSourceAwsDxPrivateVirtualInterface() (type *"github.com/hashicorp/terraform/helper/schema".Resource) as type *"github.com/hashicorp/terraform-plugin-sdk/helper/schema".Resource in map value
aws/data_source_aws_dx_private_virtual_interface_test.go:25:3: cannot use testAccProviders (type map[string]"github.com/hashicorp/terraform-plugin-sdk/terraform".ResourceProvider) as type map[string]"github.com/hashicorp/terraform/terraform".ResourceProvider in field value
FAIL    github.com/terraform-providers/terraform-provider-aws/aws [build failed]
FAIL
make: *** [testacc] Error 2

[teamterraform]

Notification of Recent and Upcoming Changes to Contributions

Thank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization.

If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items.

For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the technical-debt label on issues.

As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported.

Action Required: Terraform 0.12 Syntax

Reference: #8950
Reference: #14417

Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations (some_attribute = "${aws_service_thing.example.id}") should be updated to the newer syntax (some_attribute = aws_service_thing.example.id). Contribution testing will automatically fail on older syntax in the near future. Please see the referenced issues for additional information.

Action Required: Terraform Plugin SDK Version 2

Reference: #14551

The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information.

Action Required: Removal of website/aws.erb File

Reference: #14712

Any changes to the website/aws.erb file are no longer necessary and should be removed from this contribution to prevent merge issues in the near future when the file is removed from the repository. Please see the referenced issue for additional information.

Upcoming Change of Git Branch Naming

Reference: #14292

Development environments will need their upstream Git branch updated from master to main in the near future. Please see the referenced issue for additional information and scheduling.

Upcoming Change of GitHub Organization

Reference: #14715

This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including terraform-providers can remain for now. Please see the referenced issue for additional information and scheduling.

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.