Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Update aws_sagemaker_instance resource #8011

Closed
wants to merge 1 commit into from
Closed

[WIP] Update aws_sagemaker_instance resource #8011

wants to merge 1 commit into from

Conversation

jckuester
Copy link
Contributor

Changes proposed in this pull request:

  • Adapt aws_sagemaker_instance resource to the latest API changes

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/codebuild Issues and PRs that pertain to the codebuild service. service/glue Issues and PRs that pertain to the glue service. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 19, 2019
@jckuester jckuester force-pushed the feature/aws_sagemaker_instance_update branch from 6b125cd to 6461bc0 Compare March 19, 2019 15:56
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/autoscaling Issues and PRs that pertain to the autoscaling service. and removed size/XXL Managed by automation to categorize the size of a PR. labels Mar 19, 2019
@jckuester jckuester force-pushed the feature/aws_sagemaker_instance_update branch from 6461bc0 to b48cfc5 Compare March 19, 2019 15:56
@jckuester jckuester mentioned this pull request Mar 19, 2019
Closed
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed provider Pertains to the provider itself, rather than any interaction with AWS. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/codebuild Issues and PRs that pertain to the codebuild service. service/glue Issues and PRs that pertain to the glue service. labels Mar 26, 2019
@bflad
Copy link
Contributor

bflad commented Mar 26, 2019 •
edited
Loading

Once #7585, #7586, and #7884 are merged we can take a look at this here. 👍

@jckuester jckuester force-pushed the feature/aws_sagemaker_instance_update branch from b48cfc5 to 71902df Compare April 10, 2019 19:17
@jckuester jckuester force-pushed the feature/aws_sagemaker_instance_update branch from 71902df to 2da8bdd Compare April 11, 2019 07:46
@bflad
Copy link
Contributor

bflad commented Apr 25, 2019

Hi @jckuester 👋 Are you planning on continuing work on this pull request? No worries if not, just trying to access when we should look at it again. Thanks.

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Apr 25, 2019
@jckuester
Copy link
Contributor Author

Yes, I will finish it. Just need a week or so to find some time.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Apr 26, 2019
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label May 7, 2019
@kylebechtel77 kylebechtel77 mentioned this pull request Jun 5, 2019
Closed
@bflad
Copy link
Contributor

bflad commented Jun 21, 2019

This pull request has been superseded by #8880

@bflad bflad closed this Jun 21, 2019
@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jckuester @bflad