Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/directconnect: First half of support for Gateway Association Proposals #8320

Merged
merged 5 commits into from
Apr 24, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions aws/data_source_aws_dx_gateway.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ func dataSourceAwsDxGateway() *schema.Resource {
Type: schema.TypeString,
Required: true,
},
"owner_account_id": {
Type: schema.TypeString,
Computed: true,
},
},
}
}
Expand Down Expand Up @@ -61,6 +65,7 @@ func dataSourceAwsDxGatewayRead(d *schema.ResourceData, meta interface{}) error

d.SetId(aws.StringValue(gateway.DirectConnectGatewayId))
d.Set("amazon_side_asn", strconv.FormatInt(aws.Int64Value(gateway.AmazonSideAsn), 10))
d.Set("owner_account_id", aws.StringValue(gateway.OwnerAccount))

return nil
}
1 change: 1 addition & 0 deletions aws/data_source_aws_dx_gateway_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ func TestAccDataSourceAwsDxGateway_Basic(t *testing.T) {
resource.TestCheckResourceAttrPair(datasourceName, "amazon_side_asn", resourceName, "amazon_side_asn"),
resource.TestCheckResourceAttrPair(datasourceName, "id", resourceName, "id"),
resource.TestCheckResourceAttrPair(datasourceName, "name", resourceName, "name"),
resource.TestCheckResourceAttrPair(datasourceName, "owner_account_id", resourceName, "owner_account_id"),
),
},
},
Expand Down
1 change: 1 addition & 0 deletions aws/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,7 @@ func Provider() terraform.ResourceProvider {
"aws_dx_connection_association": resourceAwsDxConnectionAssociation(),
"aws_dx_gateway": resourceAwsDxGateway(),
"aws_dx_gateway_association": resourceAwsDxGatewayAssociation(),
"aws_dx_gateway_association_proposal": resourceAwsDxGatewayAssociationProposal(),
"aws_dx_hosted_private_virtual_interface": resourceAwsDxHostedPrivateVirtualInterface(),
"aws_dx_hosted_private_virtual_interface_accepter": resourceAwsDxHostedPrivateVirtualInterfaceAccepter(),
"aws_dx_hosted_public_virtual_interface": resourceAwsDxHostedPublicVirtualInterface(),
Expand Down
5 changes: 5 additions & 0 deletions aws/resource_aws_dx_gateway.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ func resourceAwsDxGateway() *schema.Resource {
ForceNew: true,
ValidateFunc: validateAmazonSideAsn,
},
"owner_account_id": {
Type: schema.TypeString,
Computed: true,
},
},

Timeouts: &schema.ResourceTimeout{
Expand Down Expand Up @@ -96,6 +100,7 @@ func resourceAwsDxGatewayRead(d *schema.ResourceData, meta interface{}) error {
dxGw := dxGwRaw.(*directconnect.Gateway)
d.Set("name", aws.StringValue(dxGw.DirectConnectGatewayName))
d.Set("amazon_side_asn", strconv.FormatInt(aws.Int64Value(dxGw.AmazonSideAsn), 10))
d.Set("owner_account_id", aws.StringValue(dxGw.OwnerAccount))

return nil
}
Expand Down
197 changes: 197 additions & 0 deletions aws/resource_aws_dx_gateway_association_proposal.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,197 @@
package aws

import (
"fmt"
"log"

"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/directconnect"
"github.com/hashicorp/terraform/helper/schema"
)

func resourceAwsDxGatewayAssociationProposal() *schema.Resource {
return &schema.Resource{
Create: resourceAwsDxGatewayAssociationProposalCreate,
Read: resourceAwsDxGatewayAssociationProposalRead,
Delete: resourceAwsDxGatewayAssociationProposalDelete,
Importer: &schema.ResourceImporter{
State: schema.ImportStatePassthrough,
},

Schema: map[string]*schema.Schema{
"allowed_prefixes": {
Type: schema.TypeSet,
Optional: true,
Computed: true,
ForceNew: true,
Elem: &schema.Schema{Type: schema.TypeString},
},
"dx_gateway_id": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
},
"dx_gateway_owner_account_id": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: validateAwsAccountId,
},
"vpn_gateway_id": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
},
},
}
}

func resourceAwsDxGatewayAssociationProposalCreate(d *schema.ResourceData, meta interface{}) error {
conn := meta.(*AWSClient).dxconn

input := &directconnect.CreateDirectConnectGatewayAssociationProposalInput{
AddAllowedPrefixesToDirectConnectGateway: expandDirectConnectGatewayAssociationProposalAllowedPrefixes(d.Get("allowed_prefixes").(*schema.Set).List()),
DirectConnectGatewayId: aws.String(d.Get("dx_gateway_id").(string)),
DirectConnectGatewayOwnerAccount: aws.String(d.Get("dx_gateway_owner_account_id").(string)),
GatewayId: aws.String(d.Get("vpn_gateway_id").(string)),
}

log.Printf("[DEBUG] Creating Direct Connect Gateway Association Proposal: %s", input)
output, err := conn.CreateDirectConnectGatewayAssociationProposal(input)

if err != nil {
return fmt.Errorf("error creating Direct Connect Gateway Association Proposal: %s", err)
}

d.SetId(aws.StringValue(output.DirectConnectGatewayAssociationProposal.ProposalId))

return resourceAwsDxGatewayAssociationProposalRead(d, meta)
}

func resourceAwsDxGatewayAssociationProposalRead(d *schema.ResourceData, meta interface{}) error {
conn := meta.(*AWSClient).dxconn

proposal, err := describeDirectConnectGatewayAssociationProposal(conn, d.Id())

if err != nil {
return fmt.Errorf("error reading Direct Connect Gateway Association Proposal (%s): %s", d.Id(), err)
}

if proposal == nil {
log.Printf("[WARN] Direct Connect Gateway Association Proposal (%s) not found, removing from state", d.Id())
d.SetId("")
return nil
}

if aws.StringValue(proposal.ProposalState) == directconnect.GatewayAssociationProposalStateDeleted {
log.Printf("[WARN] Direct Connect Gateway Association Proposal (%s) deleted, removing from state", d.Id())
d.SetId("")
return nil
}

if proposal.AssociatedGateway == nil {
return fmt.Errorf("error reading Direct Connect Gateway Association Proposal (%s): missing associated gateway information", d.Id())
}

if err := d.Set("allowed_prefixes", flattenDirectConnectGatewayAssociationProposalAllowedPrefixes(proposal.RequestedAllowedPrefixesToDirectConnectGateway)); err != nil {
return fmt.Errorf("error setting allowed_prefixes: %s", err)
}

d.Set("dx_gateway_id", aws.StringValue(proposal.DirectConnectGatewayId))
d.Set("dx_gateway_owner_account_id", aws.StringValue(proposal.DirectConnectGatewayOwnerAccount))
d.Set("vpn_gateway_id", aws.StringValue(proposal.AssociatedGateway.Id))

return nil
}

func resourceAwsDxGatewayAssociationProposalDelete(d *schema.ResourceData, meta interface{}) error {
conn := meta.(*AWSClient).dxconn

input := &directconnect.DeleteDirectConnectGatewayAssociationProposalInput{
ProposalId: aws.String(d.Id()),
}

log.Printf("[DEBUG] Deleting Direct Connect Gateway Association Proposal: %s", d.Id())

_, err := conn.DeleteDirectConnectGatewayAssociationProposal(input)

if err != nil {
return fmt.Errorf("error deleting Direct Connect Gateway Association Proposal (%s): %s", d.Id(), err)
}

return nil
}

func describeDirectConnectGatewayAssociationProposal(conn *directconnect.DirectConnect, proposalID string) (*directconnect.GatewayAssociationProposal, error) {
input := &directconnect.DescribeDirectConnectGatewayAssociationProposalsInput{
ProposalId: aws.String(proposalID),
}

for {
output, err := conn.DescribeDirectConnectGatewayAssociationProposals(input)

if err != nil {
return nil, err
}

if output == nil {
continue
}

for _, proposal := range output.DirectConnectGatewayAssociationProposals {
if aws.StringValue(proposal.ProposalId) == proposalID {
return proposal, nil
}
}

if aws.StringValue(output.NextToken) == "" {
break
}

input.NextToken = output.NextToken
}

return nil, nil
}

func expandDirectConnectGatewayAssociationProposalAllowedPrefixes(allowedPrefixes []interface{}) []*directconnect.RouteFilterPrefix {
if len(allowedPrefixes) == 0 {
return nil
}

var routeFilterPrefixes []*directconnect.RouteFilterPrefix

for _, allowedPrefixRaw := range allowedPrefixes {
if allowedPrefixRaw == nil {
continue
}

routeFilterPrefix := &directconnect.RouteFilterPrefix{
Cidr: aws.String(allowedPrefixRaw.(string)),
}

routeFilterPrefixes = append(routeFilterPrefixes, routeFilterPrefix)
}

return routeFilterPrefixes
}

func flattenDirectConnectGatewayAssociationProposalAllowedPrefixes(routeFilterPrefixes []*directconnect.RouteFilterPrefix) []interface{} {
if len(routeFilterPrefixes) == 0 {
return []interface{}{}
}

var allowedPrefixes []interface{}

for _, routeFilterPrefix := range routeFilterPrefixes {
if routeFilterPrefix == nil {
continue
}

allowedPrefix := aws.StringValue(routeFilterPrefix.Cidr)

allowedPrefixes = append(allowedPrefixes, allowedPrefix)
}

return allowedPrefixes
}
Loading