Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/directconnect: First half of support for Gateway Association Proposals #8320

Merged
merged 5 commits into from
Apr 24, 2019
Merged

service/directconnect: First half of support for Gateway Association Proposals #8320

merged 5 commits into from
Apr 24, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 16, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #8100

The second half of this support should be based on #8199

Changes proposed in this pull request:

  • data-source/aws_dx_gateway: Add owner_account_id attribute
  • resource/aws_dx_gateway: Add owner_account_id attribute
  • New Resource: aws_dx_gateway_association_proposal
  • docs/resource/aws_dx_gateway_association: Cross link new aws_dx_gateway_association_proposal resource

Output from acceptance testing:

--- PASS: TestAccAwsDxGateway_basic (32.10s)

--- PASS: TestAccDataSourceAwsDxGateway_Basic (36.63s)

--- PASS: TestAccAwsDxGatewayAssociationProposal_disappears (56.84s)
--- PASS: TestAccAwsDxGatewayAssociationProposal_basic (58.66s)
--- PASS: TestAccAwsDxGatewayAssociationProposal_AllowedPrefixes (76.24s)

bflad added 5 commits April 15, 2019 19:45
@bflad
resource/aws_dx_gateway: Add owner_account_id attribute
91d106f 
Reference: #8100

Output from acceptance testing:

```
--- PASS: TestAccAwsDxGateway_basic (32.10s)
```
@bflad
data-source/aws_dx_gateway: Add owner_account_id attribute
55af48d 
Reference: #8100

Output from acceptance testing:

```
--- PASS: TestAccDataSourceAwsDxGateway_Basic (36.63s)
```
@bflad
New Resource: aws_dx_gateway_association_proposal
1af4870 
Reference: #8100

Output from acceptance testing:

```
--- PASS: TestAccAwsDxGatewayAssociationProposal_disappears (56.84s)
--- PASS: TestAccAwsDxGatewayAssociationProposal_basic (58.66s)
--- PASS: TestAccAwsDxGatewayAssociationProposal_AllowedPrefixes (76.24s)
```
@bflad
service/directconnect: go fmt
2e7b488
@bflad
docs/resource/aws_dx_gateway_association: Cross link new aws_dx_gatew…
6b82e24 
…ay_association_proposal resource

Reference: #8100
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/directconnect Issues and PRs that pertain to the directconnect service. labels Apr 16, 2019
@bflad bflad requested a review from a team April 16, 2019 01:42
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 16, 2019
@bflad bflad mentioned this pull request Apr 16, 2019
Closed
@ewbankkit
Copy link
Contributor

@bflad Thanks for tackling this; I was out last week. Shall I continue with the second half of this?
#8199 is at the state I got to before I left for my trip.

@bflad
Copy link
Contributor Author

bflad commented Apr 24, 2019

@ewbankkit once #8199 has been merged (happening very shortly) and this PR has been reviewed/merged (hopefully this week), it would be very appreciated. 💯

bflad added a commit that referenced this pull request Apr 24, 2019
@bflad
docs/resource/aws_dx_gateway_association: Minor fixes based on PR #8320…
84f54d9 
… feedback

Reference: #8222 (review)
nywilken
nywilken approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@ewbankkit
Copy link
Contributor

@bflad I should be able to get to the second half at the end of this week.

@bflad bflad added this to the v2.8.0 milestone Apr 24, 2019
@bflad bflad merged commit f825d98 into master Apr 24, 2019
@bflad bflad deleted the f-aws_dx_gateway_association_proposal branch April 24, 2019 23:55
bflad added a commit that referenced this pull request Apr 24, 2019
@bflad
Update CHANGELOG for #8320
bc0b73a
@ewbankkit ewbankkit mentioned this pull request Apr 26, 2019
Closed
@nywilken
Copy link
Contributor

nywilken commented Apr 27, 2019 •
edited
Loading

This has been released in version 2.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ewbankkit ewbankkit mentioned this pull request May 1, 2019
Closed
@ewbankkit ewbankkit mentioned this pull request May 9, 2019
Merged
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/directconnect Issues and PRs that pertain to the directconnect service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bflad @ewbankkit @nywilken