r/aws_dx_gateway_association: Update for transit gateway support plus the second half (cross-account proposal acceptance) of support for Gateway Association Proposals #8528

ewbankkit · 2019-05-04T23:10:18Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Transit gateway support

Part of the work for #8490.

Cross-account proposal acceptance

Fixes #8100.
Follows on from:

Release note for CHANGELOG:

NOTES:

* resource/aws_dx_gateway_association: The `vpn_gateway_id` attribute is being deprecated in favor of the new `associated_gateway_id` attribute to support transit gateway associations (https://github.com/terraform-providers/terraform-provider-aws/issues/8490)
* resource/aws_dx_gateway_association_proposal: The `vpn_gateway_id` attribute is being deprecated in favor of the new `associated_gateway_id` attribute to support transit gateway associations (https://github.com/terraform-providers/terraform-provider-aws/issues/8490)

ENHANCEMENTS:

* resource/aws_dx_gateway_association: New attributes `associated_gateway_owner_account_id` and `proposal_id` added to support the acceptance of a Direct Connect gateway association proposal and create a cross-account Direct Connect gateway association (https://github.com/terraform-providers/terraform-provider-aws/issues/8100).
New attribute `associated_gateway_id` replaces deprecated `vpn_gateway_id` attribute to support transit gateway associations (https://github.com/terraform-providers/terraform-provider-aws/issues/8490).
New exported attributes `associated_gateway_type` and `dx_gateway_owner_account_id`
* resource/aws_dx_gateway_association_proposal: New attribute `associated_gateway_id` replaces deprecated `vpn_gateway_id` attribute to support transit gateway associations (https://github.com/terraform-providers/terraform-provider-aws/issues/8490).
New exported attributes `associated_gateway_owner_account_id` and `associated_gateway_type`

ewbankkit · 2019-05-09T01:30:31Z

More success with acceptance tests having cherry picked the commit from #8576:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxGatewayAssociation_deprecated'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsDxGatewayAssociation_deprecated -timeout 120m
=== RUN   TestAccAwsDxGatewayAssociation_deprecated
=== PAUSE TestAccAwsDxGatewayAssociation_deprecated
=== CONT  TestAccAwsDxGatewayAssociation_deprecated
--- PASS: TestAccAwsDxGatewayAssociation_deprecated (1381.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1381.806s

ewbankkit · 2019-05-09T13:56:08Z

This PR will now incorporate the cross-account Gateway Proposal acceptance work started in #8455. These changes will be incorporated into the aws_dx_gateway_association resource rather than creating a new aws_dx_cross_account_gateway_association resource.

ewbankkit · 2019-05-10T23:05:59Z

Cross-account Direct Connect gateway association changes from #8455 have been incorporated and all acceptance tests are now passing. Note that I am including the commit from #8576 to ensure that VGW associations are correctly cleaned up.

aws_dx_gateway_association_proposal

$ AWS_ALTERNATE_ACCESS_KEY_ID=AAAAAAAAAAAAAAAAAAAA AWS_ALTERNATE_SECRET_ACCESS_KEY=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxGatewayAssociationProposal_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 2 -run=TestAccAwsDxGatewayAssociationProposal_ -timeout 120m
=== RUN   TestAccAwsDxGatewayAssociationProposal_deprecated
=== PAUSE TestAccAwsDxGatewayAssociationProposal_deprecated
=== RUN   TestAccAwsDxGatewayAssociationProposal_basicVpnGateway
=== PAUSE TestAccAwsDxGatewayAssociationProposal_basicVpnGateway
=== RUN   TestAccAwsDxGatewayAssociationProposal_basicTransitGateway
=== PAUSE TestAccAwsDxGatewayAssociationProposal_basicTransitGateway
=== RUN   TestAccAwsDxGatewayAssociationProposal_disappears
=== PAUSE TestAccAwsDxGatewayAssociationProposal_disappears
=== RUN   TestAccAwsDxGatewayAssociationProposal_allowedPrefixes
=== PAUSE TestAccAwsDxGatewayAssociationProposal_allowedPrefixes
=== CONT  TestAccAwsDxGatewayAssociationProposal_deprecated
=== CONT  TestAccAwsDxGatewayAssociationProposal_allowedPrefixes
--- PASS: TestAccAwsDxGatewayAssociationProposal_deprecated (71.43s)
=== CONT  TestAccAwsDxGatewayAssociationProposal_disappears
--- PASS: TestAccAwsDxGatewayAssociationProposal_allowedPrefixes (94.61s)
=== CONT  TestAccAwsDxGatewayAssociationProposal_basicTransitGateway
--- PASS: TestAccAwsDxGatewayAssociationProposal_disappears (58.27s)
=== CONT  TestAccAwsDxGatewayAssociationProposal_basicVpnGateway
--- PASS: TestAccAwsDxGatewayAssociationProposal_basicVpnGateway (60.52s)
--- PASS: TestAccAwsDxGatewayAssociationProposal_basicTransitGateway (146.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	240.815s

aws_dx_gateway_association

$ AWS_ALTERNATE_ACCESS_KEY_ID=AAAAAAAAAAAAAAAAAAAA AWS_ALTERNATE_SECRET_ACCESS_KEY=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxGatewayAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 2 -run=TestAccAwsDxGatewayAssociation_ -timeout 120m
=== RUN   TestAccAwsDxGatewayAssociation_deprecatedSingleAccount
=== PAUSE TestAccAwsDxGatewayAssociation_deprecatedSingleAccount
=== RUN   TestAccAwsDxGatewayAssociation_basicVpnGatewaySingleAccount
=== PAUSE TestAccAwsDxGatewayAssociation_basicVpnGatewaySingleAccount
=== RUN   TestAccAwsDxGatewayAssociation_basicVpnGatewayCrossAccount
=== PAUSE TestAccAwsDxGatewayAssociation_basicVpnGatewayCrossAccount
=== RUN   TestAccAwsDxGatewayAssociation_basicTransitGatewaySingleAccount
=== PAUSE TestAccAwsDxGatewayAssociation_basicTransitGatewaySingleAccount
=== RUN   TestAccAwsDxGatewayAssociation_basicTransitGatewayCrossAccount
=== PAUSE TestAccAwsDxGatewayAssociation_basicTransitGatewayCrossAccount
=== RUN   TestAccAwsDxGatewayAssociation_multiVpnGatewaysSingleAccount
=== PAUSE TestAccAwsDxGatewayAssociation_multiVpnGatewaysSingleAccount
=== RUN   TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewaySingleAccount
=== PAUSE TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewaySingleAccount
=== RUN   TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewayCrossAccount
=== PAUSE TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewayCrossAccount
=== CONT  TestAccAwsDxGatewayAssociation_deprecatedSingleAccount
=== CONT  TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewayCrossAccount
--- PASS: TestAccAwsDxGatewayAssociation_deprecatedSingleAccount (1348.63s)
=== CONT  TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewaySingleAccount
--- PASS: TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewayCrossAccount (1885.66s)
=== CONT  TestAccAwsDxGatewayAssociation_multiVpnGatewaysSingleAccount
--- PASS: TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewaySingleAccount (2193.34s)
=== CONT  TestAccAwsDxGatewayAssociation_basicTransitGatewayCrossAccount
--- PASS: TestAccAwsDxGatewayAssociation_multiVpnGatewaysSingleAccount (1657.42s)
=== CONT  TestAccAwsDxGatewayAssociation_basicTransitGatewaySingleAccount
--- PASS: TestAccAwsDxGatewayAssociation_basicTransitGatewaySingleAccount (1232.65s)
=== CONT  TestAccAwsDxGatewayAssociation_basicVpnGatewayCrossAccount
--- PASS: TestAccAwsDxGatewayAssociation_basicTransitGatewayCrossAccount (1235.44s)
=== CONT  TestAccAwsDxGatewayAssociation_basicVpnGatewaySingleAccount
--- PASS: TestAccAwsDxGatewayAssociation_basicVpnGatewaySingleAccount (1844.14s)
--- PASS: TestAccAwsDxGatewayAssociation_basicVpnGatewayCrossAccount (1847.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	6623.071s

ewbankkit · 2019-05-10T23:07:01Z

~~Still TODO:~~
* Add CHANGELOG notes

ewbankkit · 2019-05-10T23:10:12Z

aws/resource_aws_dx_gateway_association.go

+	d.Set("dx_gateway_owner_account_id", assoc.DirectConnectGatewayOwnerAccount)
+
+	tgwAttachmentId := ""
+	if aws.StringValue(assoc.AssociatedGateway.Type) == directconnect.GatewayTypeTransitGateway {


We need to get the transit gateway attachment here to ensure that we wait for it's deletion when this resource is deleted.
See discussion: #8490 (comment).
Maybe move this code plus ec2TransitGatewayAttachmentStateRefresh() and waitForEc2TransitGatewayAttachmentDeletion() below to ec2_transit_gateway.go?

Logic for storing the AttachmentID should be removed from this resource. The logic for properly handling the deletion error has non-deleted DirectConnect Gateway Attachment needs to be addressed in the existing aws_ec2_transit_gateway resource as a separate PR. Please see my comment below.

ewbankkit · 2019-05-10T23:14:39Z

Removing WIP as now ready for review,

ewbankkit · 2019-05-13T19:13:23Z

Rebased to remove the fixes incorporated in #8576.

aleksap · 2019-05-13T19:28:38Z

Hi @ewbankkit ! So looks like you have code ready, it just needs to be merged?

ewbankkit · 2019-05-13T20:08:57Z

@aleksap Functionality is complete, a review is required.

nywilken

Hi @ewbankkit thanks for your patience on this PR. I think the the single resource with the ability to handle single, and cross, account proposals is easier to follow and use. I am in the middle of the review, but I do have some quick suggestions for you. Please let me know if you have an questions so far.

nywilken · 2019-05-16T18:02:40Z

aws/resource_aws_dx_gateway_association_proposal.go

+	gwIdRaw, gwIdOk := d.GetOk("associated_gateway_id")
+	vgwIdRaw, vgwIdOk := d.GetOk("vpn_gateway_id")
+	if !gwIdOk && !vgwIdOk {
+		return errors.New("one of associated_gateway_id or vpn_gateway_id must be configured")


Let's use fmt.Errorf to keep error creation consistent across this code base.

nywilken · 2019-05-16T18:58:50Z

aws/resource_aws_dx_gateway_association_proposal.go

 	input := &directconnect.CreateDirectConnectGatewayAssociationProposalInput{
 		AddAllowedPrefixesToDirectConnectGateway: expandDirectConnectGatewayAssociationProposalAllowedPrefixes(d.Get("allowed_prefixes").(*schema.Set).List()),
 		DirectConnectGatewayId:                   aws.String(d.Get("dx_gateway_id").(string)),
 		DirectConnectGatewayOwnerAccount:         aws.String(d.Get("dx_gateway_owner_account_id").(string)),
-		GatewayId:                                aws.String(d.Get("vpn_gateway_id").(string)),
+	}
+	if gwIdOk {


Having this conditional and the conditional on line 89 separated by a directconnect.CreateDirectConnectGatewayAssociationProposalInput creation makes this a bit difficult to follow. I suggest replacing lines 89 - 104 with the following

allowedPrefixes := expandDirectConnectGatewayAssociationProposalAllowedPrefixes(d.Get("allowed_prefixes").(*schema.Set).List()) input := &directconnect.CreateDirectConnectGatewayAssociationProposalInput{ AddAllowedPrefixesToDirectConnectGateway: allowedPrefixes, DirectConnectGatewayId: aws.String(d.Get("dx_gateway_id").(string)), DirectConnectGatewayOwnerAccount: aws.String(d.Get("dx_gateway_owner_account_id").(string)), } var gwID string if v, ok := d.GetOk("vpn_gateway_id"); ok { gwID = v.(string) } else if v, ok := d.GetOk("associated_gateway_id"); ok { gwID = v.(string) } if gwID == "" { return fmt.Errorf("gateway id not provided, one of associated_gateway_id or vpn_gateway_id must be configured") } input.GatewayId = aws.String(gwID)

nywilken · 2019-05-16T19:07:20Z

aws/resource_aws_dx_gateway_association_proposal_test.go

@@ -71,7 +152,7 @@ func TestAccAwsDxGatewayAssociationProposal_disappears(t *testing.T) {
 	})
 }

-func TestAccAwsDxGatewayAssociationProposal_AllowedPrefixes(t *testing.T) {
+func TestAccAwsDxGatewayAssociationProposal_allowedPrefixes(t *testing.T) {


The convention is to camelcase the argument names so that they match their respective AWS SDK names.

nywilken · 2019-05-16T19:56:59Z

aws/resource_aws_dx_gateway_association_test.go

@@ -101,7 +102,7 @@ func testSweepDirectConnectGatewayAssociations(region string) error {
 	return nil
 }

-func TestAccAwsDxGatewayAssociation_basic(t *testing.T) {
+func TestAccAwsDxGatewayAssociation_deprecatedSingleAccount(t *testing.T) {


We don't tend to rename or change existing tests on attribute deprecation as they should continue to work with the deprecated fields. Instead you should add a test case that goes from the deprecated attribute to the new attribute TestAccAwsDxGatewayAssociation_VpnGatewayId_Migration_AssociatedGatewayId

…_association.

Review comment. Co-Authored-By: Wilken Rivera <dev@wilkenrivera.com>

nywilken · 2019-05-23T19:30:11Z

website/docs/r/dx_gateway_association.html.markdown

-  associated_gateway_owner_account_id = "${data.aws_caller_identity.creator.account_id}"
-}
-```
+A full example of how to to create a VPN Gateway in one AWS account, create a Direct Connect Gateway in a second AWS account, and associate the VPN Gateway with the Direct Connect Gateway via the `aws_dx_gateway_association_proposal` and `aws_dx_gateway_association` resources can be found in [the `./examples/dx-gateway-cross-account-vgw-association` directory within the Github Repository](https://github.com/terraform-providers/terraform-provider-aws/tree/master/examples/dx-gateway-cross-account-vgw-association).


to there's an extra "to"

nywilken · 2019-05-23T19:30:53Z

website/docs/r/dx_gateway_association_proposal.html.markdown

 ```

+A full example of how to to create a VPN Gateway in one AWS account, create a Direct Connect Gateway in a second AWS account, and associate the VPN Gateway with the Direct Connect Gateway via the `aws_dx_gateway_association_proposal` and `aws_dx_gateway_association` resources can be found in [the `./examples/dx-gateway-cross-account-vgw-association` directory within the Github Repository](https://github.com/terraform-providers/terraform-provider-aws/tree/master/examples/dx-gateway-cross-account-vgw-association).


nywilken · 2019-05-23T19:32:09Z

examples/dx-gateway-cross-account-vgw-association/README.md

@@ -0,0 +1,18 @@
+# Direct Connect Gateway Cross-Account VGW Association


💯 Good call on moving this out to the examples directory.

ewbankkit · 2019-05-23T20:02:17Z

Rebased from master with fixes from #8752.

ewbankkit · 2019-05-23T20:37:21Z

Acceptance tests:

$ AWS_ALTERNATE_ACCESS_KEY_ID=AAAAAAAAAAAAAAAAAAAA AWS_ALTERNATE_SECRET_ACCESS_KEY=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxGatewayAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 2 -run=TestAccAwsDxGatewayAssociation_ -timeout 120m
=== RUN   TestAccAwsDxGatewayAssociation_deprecatedSingleAccount
=== PAUSE TestAccAwsDxGatewayAssociation_deprecatedSingleAccount
=== RUN   TestAccAwsDxGatewayAssociation_basicVpnGatewaySingleAccount
=== PAUSE TestAccAwsDxGatewayAssociation_basicVpnGatewaySingleAccount
=== RUN   TestAccAwsDxGatewayAssociation_basicVpnGatewayCrossAccount
=== PAUSE TestAccAwsDxGatewayAssociation_basicVpnGatewayCrossAccount
=== RUN   TestAccAwsDxGatewayAssociation_basicTransitGatewaySingleAccount
=== PAUSE TestAccAwsDxGatewayAssociation_basicTransitGatewaySingleAccount
=== RUN   TestAccAwsDxGatewayAssociation_basicTransitGatewayCrossAccount
=== PAUSE TestAccAwsDxGatewayAssociation_basicTransitGatewayCrossAccount
=== RUN   TestAccAwsDxGatewayAssociation_multiVpnGatewaysSingleAccount
=== PAUSE TestAccAwsDxGatewayAssociation_multiVpnGatewaysSingleAccount
=== RUN   TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewaySingleAccount
=== PAUSE TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewaySingleAccount
=== RUN   TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewayCrossAccount
=== PAUSE TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewayCrossAccount
=== CONT  TestAccAwsDxGatewayAssociation_deprecatedSingleAccount
=== CONT  TestAccAwsDxGatewayAssociation_multiVpnGatewaysSingleAccount
--- PASS: TestAccAwsDxGatewayAssociation_deprecatedSingleAccount (1356.21s)
=== CONT  TestAccAwsDxGatewayAssociation_basicTransitGatewayCrossAccount
--- PASS: TestAccAwsDxGatewayAssociation_multiVpnGatewaysSingleAccount (1356.50s)
=== CONT  TestAccAwsDxGatewayAssociation_basicTransitGatewaySingleAccount
--- PASS: TestAccAwsDxGatewayAssociation_basicTransitGatewaySingleAccount (1760.16s)
=== CONT  TestAccAwsDxGatewayAssociation_basicVpnGatewayCrossAccount
--- FAIL: TestAccAwsDxGatewayAssociation_basicTransitGatewayCrossAccount (1762.87s)
    testing.go:568: Step 0 error: errors during apply:
        
        Error: error waiting for Direct Connect gateway association (ga-xxxxxxxx) to become available: timeout while waiting for state to become 'associated' (last state: 'associating', timeout: 15m0s)
        
          on /var/folders/4j/lf5jdq5j4y91g80ytf6qzjwmk6drp5/T/tf-test232917661/main.tf line 39:
          (source code not available)
        
        
=== CONT  TestAccAwsDxGatewayAssociation_basicVpnGatewaySingleAccount
--- PASS: TestAccAwsDxGatewayAssociation_basicVpnGatewaySingleAccount (1966.67s)
=== CONT  TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewayCrossAccount
--- PASS: TestAccAwsDxGatewayAssociation_basicVpnGatewayCrossAccount (1971.17s)
=== CONT  TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewaySingleAccount
panic: test timed out after 2h0m0s

I don't think these failures are anything to do with the changes but would like independent verification.

nywilken · 2019-05-23T22:20:01Z

Running the test by itself appears to work properly. Have you tried updating the timeout interval to see if all tests pass without timeout? I'm currently running that now with a 30 minute timeout.

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsDxGatewayAssociation_basicTransitGatewayCrossAccount -timeout 120m
=== RUN   TestAccAwsDxGatewayAssociation_basicTransitGatewayCrossAccount
=== PAUSE TestAccAwsDxGatewayAssociation_basicTransitGatewayCrossAccount
=== CONT  TestAccAwsDxGatewayAssociation_basicTransitGatewayCrossAccount
--- PASS: TestAccAwsDxGatewayAssociation_basicTransitGatewayCrossAccount (1480.06s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1480.093s

In the meantime, I am looking to see if there are any missing pieces as @bflad pointed me to this note The transit gateway must be attached to a VPC or VPN in your AWS account. here

nywilken

@ewbankkit each of the tests past individually. Adding additional timing (e.g 30 minutes) does not change much. I've seen the VpnGateway and TransitGateway test time out when trying to run all the tests in parallel at various times.

I am going to approve this PR as I would like to get this out with v2.12.0 release. Lets monitor its usage to see if the timeout is an issue for users. In the meantime, I will continue to dive into the tests.

Thanks for the time and patience. Nicely done 👍

bflad · 2019-05-24T11:23:01Z

This has been released in version 2.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

aleksap · 2019-06-10T18:26:11Z

@ewbankkit @nywilken
Hello,

Thank you for your work on this feature.
I have noticed that on aws_dx_gateway_association resource, argument vpn_gateway_id was deprecated in favor of associated_gateway_id.
We have tested that and it works fine.
However, when it comes to destroying those resources we get following messages:

Error: module.dx_vgw_assoc.aws_dx_gateway_association.dx_gw_assoc: "vpn_gateway_id": required field is not set
Error: module.dx_vgw_assoc.aws_dx_gateway_association.dx_gw_assoc: : invalid or unknown key: associated_gateway_id

It almost looks like that "destroy" part is not aware that vpn_gateway_id is deprecated and is not recognizing associated_gateway_id argument.

Please let me know if this makes sense and if it does should I open bug ticket.

Thank you,
Alex

ewbankkit · 2019-06-10T19:11:34Z

@aleksap Strange. It looks like somehow an earlier version of the provider (pre-v2.12.0) is being run here, hence the errors about missing vpn_gateway_id and extraneous associated_gateway_id.
Could you add a sample of Terraform code that is exhibiting this behavior?
Thanks.

aleksap · 2019-06-10T19:44:28Z

@ewbankkit I am not sure what happened but after deleting my .terraform folder and re-downloading provider it just started working!
Now, I'm pretty confident I didn't have .terraform before in that directory and can't really explain why it was doing this.
I will keep an eye for it after next build/destroy cycle and let you know if we see the same.

Thanks for the quick reply!

ghost · 2019-11-03T15:35:21Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

This was referenced May 4, 2019

Allow aws_dx_gateway_association and aws_dx_private_virtual_interface to reference Transit Gateway #8490

Closed

[WIP] Second half of support for Gateway Association Proposals #8455

Closed

ewbankkit force-pushed the issue-8490.dx_gateway_association branch from 1e1d660 to 5aa5ec6 Compare May 5, 2019 22:46

ghost added size/XL Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. and removed size/M Managed by automation to categorize the size of a PR. labels May 5, 2019

ewbankkit force-pushed the issue-8490.dx_gateway_association branch 2 times, most recently from cd5c36d to 15e5f6d Compare May 9, 2019 01:27

ewbankkit changed the title ~~[WIP] r/aws_dx_gateway_association: Update for transit gateway support~~ [WIP] r/aws_dx_gateway_association: Update for transit gateway support plus the second half (cross-account proposal acceptance) of support for Gateway Association Proposals May 9, 2019

This was referenced May 9, 2019

Direct Connect gateway multi-account support #8100

Closed

Add data source for transit gateway's Direct Connect gateway attachment #8590

Closed

ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels May 9, 2019

ewbankkit commented May 10, 2019

View reviewed changes

ewbankkit mentioned this pull request May 10, 2019

New resource: ram_resource_share_accepter #8259

Merged

ewbankkit force-pushed the issue-8490.dx_gateway_association branch from 04354ca to 5dafe20 Compare May 13, 2019 19:11

nywilken reviewed May 16, 2019

View reviewed changes

ewbankkit and others added 11 commits May 23, 2019 14:18

Add association proposal acceptance (cross-account) to aws_dx_gateway…

02afd3b

…_association.

Get all aws_dx_gateway_association_proposal acceptance tests passing.

392969d

Get all aws_dx_gateway_association acceptance tests passing.

c7b1103

Address review comments.

2605482

Update aws/resource_aws_dx_gateway_association.go

a587d74

Review comment. Co-Authored-By: Wilken Rivera <dev@wilkenrivera.com>

Update aws/resource_aws_dx_gateway_association.go

f7b19f8

Review comment. Co-Authored-By: Wilken Rivera <dev@wilkenrivera.com>

Remove EC2 Transit Gateway attachment logic.

708a9e2

Update website/docs/r/dx_gateway_association.html.markdown

23529da

Review comment. Co-Authored-By: Wilken Rivera <dev@wilkenrivera.com>

Update website/docs/r/dx_gateway_association.html.markdown

bf2bb30

Review comment. Co-Authored-By: Wilken Rivera <dev@wilkenrivera.com>

Documentation review changes.

97c9900

New cross-account Direct Connect gateway association example.

473e206

nywilken reviewed May 23, 2019

View reviewed changes

Fix minor documentation typo.

93e2df2

ewbankkit force-pushed the issue-8490.dx_gateway_association branch from f775493 to 93e2df2 Compare May 23, 2019 20:01

nywilken approved these changes May 24, 2019

View reviewed changes

nywilken merged commit 08f2a8f into hashicorp:master May 24, 2019

nywilken added a commit that referenced this pull request May 24, 2019

update CHANGELOG for #8528

d04a2e4

ewbankkit deleted the issue-8490.dx_gateway_association branch May 24, 2019 09:41

ewbankkit mentioned this pull request Jun 12, 2019

dx_gateway association import throws error #8956

Closed

ghost locked and limited conversation to collaborators Nov 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_dx_gateway_association: Update for transit gateway support plus the second half (cross-account proposal acceptance) of support for Gateway Association Proposals #8528

r/aws_dx_gateway_association: Update for transit gateway support plus the second half (cross-account proposal acceptance) of support for Gateway Association Proposals #8528

ewbankkit commented May 4, 2019 •

edited

Loading

ewbankkit commented May 9, 2019

ewbankkit commented May 9, 2019

ewbankkit commented May 10, 2019

ewbankkit commented May 10, 2019 •

edited

Loading

ewbankkit May 10, 2019

nywilken May 22, 2019

ewbankkit commented May 10, 2019

ewbankkit commented May 13, 2019

aleksap commented May 13, 2019

ewbankkit commented May 13, 2019

nywilken left a comment •

edited

Loading

nywilken May 16, 2019

nywilken May 16, 2019

nywilken May 16, 2019

nywilken May 16, 2019

nywilken May 23, 2019 •

edited

Loading

nywilken May 23, 2019

nywilken May 23, 2019

ewbankkit commented May 23, 2019

ewbankkit commented May 23, 2019 •

edited

Loading

nywilken commented May 23, 2019

nywilken left a comment

bflad commented May 24, 2019

aleksap commented Jun 10, 2019

ewbankkit commented Jun 10, 2019

aleksap commented Jun 10, 2019

ghost commented Nov 3, 2019

		```

		A full example of how to to create a VPN Gateway in one AWS account, create a Direct Connect Gateway in a second AWS account, and associate the VPN Gateway with the Direct Connect Gateway via the `aws_dx_gateway_association_proposal` and `aws_dx_gateway_association` resources can be found in [the `./examples/dx-gateway-cross-account-vgw-association` directory within the Github Repository](https://github.com/terraform-providers/terraform-provider-aws/tree/master/examples/dx-gateway-cross-account-vgw-association).

		@@ -0,0 +1,18 @@
		# Direct Connect Gateway Cross-Account VGW Association

r/aws_dx_gateway_association: Update for transit gateway support plus the second half (cross-account proposal acceptance) of support for Gateway Association Proposals #8528

r/aws_dx_gateway_association: Update for transit gateway support plus the second half (cross-account proposal acceptance) of support for Gateway Association Proposals #8528

Conversation

ewbankkit commented May 4, 2019 • edited Loading

Community Note

Transit gateway support

Cross-account proposal acceptance

ewbankkit commented May 9, 2019

ewbankkit commented May 9, 2019

ewbankkit commented May 10, 2019

aws_dx_gateway_association_proposal

aws_dx_gateway_association

ewbankkit commented May 10, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ewbankkit commented May 10, 2019

ewbankkit commented May 13, 2019

aleksap commented May 13, 2019

ewbankkit commented May 13, 2019

nywilken left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nywilken May 23, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ewbankkit commented May 23, 2019

ewbankkit commented May 23, 2019 • edited Loading

nywilken commented May 23, 2019

nywilken left a comment

Choose a reason for hiding this comment

bflad commented May 24, 2019

aleksap commented Jun 10, 2019

ewbankkit commented Jun 10, 2019

aleksap commented Jun 10, 2019

ghost commented Nov 3, 2019

ewbankkit commented May 4, 2019 •

edited

Loading

ewbankkit commented May 10, 2019 •

edited

Loading

nywilken left a comment •

edited

Loading

nywilken May 23, 2019 •

edited

Loading

ewbankkit commented May 23, 2019 •

edited

Loading