Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New data source: aws_ec2_transit_gateway_dx_gateway_attachment #8678

Merged
merged 1 commit into from
Jun 6, 2019
Merged

New data source: aws_ec2_transit_gateway_dx_gateway_attachment #8678

merged 1 commit into from
Jun 6, 2019

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8590

Release note for CHANGELOG:

FEATURES:

* New Data Source: aws_ec2_transit_gateway_dx_gateway_attachment (#8590)

WIP as this PR requires #8528 to be able to run the acceptance tests.

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/directconnect Issues and PRs that pertain to the directconnect service. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels May 17, 2019
@ewbankkit ewbankkit changed the title [WIP] New data source: aws_ec2_transit_gateway_dx_gateway_attachment New data source: aws_ec2_transit_gateway_dx_gateway_attachment May 24, 2019
@ewbankkit
Copy link
Contributor Author

Rebased after merging of #8528.

Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEc2TransitGatewayDxGatewayAttachmentDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSEc2TransitGatewayDxGatewayAttachmentDataSource_ -timeout 120m
=== RUN   TestAccAWSEc2TransitGatewayDxGatewayAttachmentDataSource_TransitGatewayIdAndDxGatewayId
=== PAUSE TestAccAWSEc2TransitGatewayDxGatewayAttachmentDataSource_TransitGatewayIdAndDxGatewayId
=== CONT  TestAccAWSEc2TransitGatewayDxGatewayAttachmentDataSource_TransitGatewayIdAndDxGatewayId
--- PASS: TestAccAWSEc2TransitGatewayDxGatewayAttachmentDataSource_TransitGatewayIdAndDxGatewayId (1297.02s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1297.042s

Removed WIP.

n3ph
n3ph reviewed Jun 6, 2019
View reviewed changes
Copy link
Contributor

@n3ph n3ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aws/data_source_aws_ec2_transit_gateway_dx_gateway_attachment.go
},
{
Name: aws.String("resource-type"),
Values: []*string{aws.String("direct-connect-gateway")}, // Not yet defined in ec2/api.go.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still the case? Looking at #8490 (comment) I thought this was already updated..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ec2.TransitGatewayAttachmentResourceTypeDirectConnectGateway has now been added in AWS SDK v1.19.46, merged via #8864.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to check the Go SDK... Right

@bflad bflad added the new-data-source Introduces a new data source. label Jun 6, 2019
@bflad bflad added this to the v2.14.0 milestone Jun 6, 2019
bflad
bflad approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @ewbankkit, thanks as usual! 🚀

Output from acceptance testing:

--- PASS: TestAccAWSEc2TransitGatewayDxGatewayAttachmentDataSource_TransitGatewayIdAndDxGatewayId (1466.49s)

@bflad bflad merged commit 2a31f16 into hashicorp:master Jun 6, 2019
bflad added a commit that referenced this pull request Jun 6, 2019
@bflad
Update CHANGELOG for #8678
4d79ab8
@ewbankkit ewbankkit deleted the issue-8590 branch June 6, 2019 21:12
@bflad
Copy link
Contributor

bflad commented Jun 7, 2019

This has been released in version 2.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@n3ph n3ph n3ph left review comments

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/directconnect Issues and PRs that pertain to the directconnect service. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.

Add data source for transit gateway's Direct Connect gateway attachment
3 participants
@ewbankkit @bflad @n3ph