Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_appmesh_route: Add support for HTTP-header-based routing and route priorities #9803

Closed
wants to merge 15 commits into from

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9802.

Release note for CHANGELOG:

resource/aws_appmesh_route: Add `priority` and `header` attributes to support route priorities and HTTP-header-based routing

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route/'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSAppmesh/Route/ -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/Route
=== RUN   TestAccAWSAppmesh/Route/tcpRoute
=== RUN   TestAccAWSAppmesh/Route/routePriority
=== RUN   TestAccAWSAppmesh/Route/tags
=== RUN   TestAccAWSAppmesh/Route/httpHeader
=== RUN   TestAccAWSAppmesh/Route/httpRoute
=== RUN   TestAccAWSAppmesh/VirtualRouter
=== RUN   TestAccAWSAppmesh/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh/VirtualRouter/tags
--- PASS: TestAccAWSAppmesh (289.67s)
    --- PASS: TestAccAWSAppmesh/Route (206.69s)
        --- PASS: TestAccAWSAppmesh/Route/tcpRoute (41.59s)
        --- PASS: TestAccAWSAppmesh/Route/routePriority (40.44s)
        --- PASS: TestAccAWSAppmesh/Route/tags (42.81s)
        --- PASS: TestAccAWSAppmesh/Route/httpHeader (41.00s)
        --- PASS: TestAccAWSAppmesh/Route/httpRoute (40.84s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (82.98s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (34.33s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/tags (48.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	289.741s

@ewbankkit ewbankkit requested a review from a team August 16, 2019 21:39
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. service/appmesh Issues and PRs that pertain to the appmesh service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 16, 2019
@ewbankkit
Copy link
Contributor Author

ewbankkit commented Aug 16, 2019

@ewbankkit
Copy link
Contributor Author

The SDK-provided constants can now be used.
Requires:

@ewbankkit
Copy link
Contributor Author

Pulled in latest AWS SDK and reverted to using the SDK-defined constants.
Re-ran acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route/'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSAppmesh/Route/ -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/Route
=== RUN   TestAccAWSAppmesh/Route/httpRoute
=== RUN   TestAccAWSAppmesh/Route/tcpRoute
=== RUN   TestAccAWSAppmesh/Route/routePriority
=== RUN   TestAccAWSAppmesh/Route/tags
=== RUN   TestAccAWSAppmesh/Route/httpHeader
=== RUN   TestAccAWSAppmesh/VirtualRouter
=== RUN   TestAccAWSAppmesh/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh/VirtualRouter/tags
--- PASS: TestAccAWSAppmesh (287.46s)
    --- PASS: TestAccAWSAppmesh/Route (203.56s)
        --- PASS: TestAccAWSAppmesh/Route/httpRoute (41.38s)
        --- PASS: TestAccAWSAppmesh/Route/tcpRoute (40.65s)
        --- PASS: TestAccAWSAppmesh/Route/routePriority (40.69s)
        --- PASS: TestAccAWSAppmesh/Route/tags (40.99s)
        --- PASS: TestAccAWSAppmesh/Route/httpHeader (39.85s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (83.90s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (34.80s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/tags (49.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	287.530s

@ewbankkit
Copy link
Contributor Author

Closing in favor of #9964.
Easier to create a new PR than deal with git rebase conflicts.

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. service/appmesh Issues and PRs that pertain to the appmesh service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS App Mesh HTTP-header-based routing and route priorities
2 participants