Support for additional settings in liveness_probe, startup_probe and readiness_probe

[pietersap]

Is there an existing issue for this?

• I have searched the existing issues

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Description

The available settings for the configuration of the liveness, readiness and startup probes in Azure Container Apps are lacking a few details.

• initial_delay: This setting is configurable in all three types of probes (liveness, readiness, startup) in Azure, but is only exposed in the liveness_probe block in the azurerm provider. It could be added to the readiness_probe and startup_probe blocks.
• initial_delay, by the way, currently has weird behaviour. It seems to default to 1, but I cannot set it to 0. So I am currently forced to set the value to 1, even if I want to set it to 0.
• success_count_threshold: This setting is configurable in all three types of probes (liveness, readiness, startup) in Azure, but is only exposed in the readiness_probe block in the azurerm provider. It could be added to the liveness_probe and startup_probe blocks.
• failure_count_threshold: available in all three types of probes, in the azurerm provider the maximum value is 10 according to the documentation. I'm not sure if this is by design in the azurerm provider, but for sure Azure allows higher values. I'm currently at 15.

New or Affected Resource(s)/Data Source(s)

azurerm_container_app

Potential Terraform Configuration

liveness_probe {
  transport               = "TCP"
  port                    = 5001
  interval_seconds        = 10
  timeout                 = 2
  success_count_threshold = 1 # missing
  failure_count_threshold = 6
  initial_delay           = 0
}
readiness_probe {
  transport               = "TCP"
  port                    = 5002
  interval_seconds        = 10
  timeout                 = 2
  success_count_threshold = 1
  failure_count_threshold = 3
  initial_delay           = 0 # missing
}
startup_probe {
  transport               = "TCP"
  port                    = 5002
  interval_seconds        = 2
  timeout                 = 2
  success_count_threshold = 1 # missing
  failure_count_threshold = 10 # current maximum in azurerm, although Azure allows higher
  initial_delay           = 0 # missing
}

[pietersap]

This issue slightly overlaps with existing issue #24845, but this issue is more complete

[yavuzkaymak]

I think terminationGracePeriodSeconds is also missing in readiness probe.

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/app/resource-manager/Microsoft.App/stable/2022-03-01/CommonDefinitions.json#L119-L236

[SpartakusMd]

Hey @yavuzkaymak, I didn't see this option in the Azure Portal. I also didn't find it in the GO SDK, while in the .NET I found it at the template level. So in the end I didn't add it to my PR. Feel free to open a separate issue for it though.