Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_container_app - Support for additional settings in liveness_probe, startup_probe and readiness_probe #26573

Conversation

SpartakusMd
Copy link
Contributor

@SpartakusMd SpartakusMd commented Jul 8, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

The available settings for the configuration of the liveness, readiness and startup probes in Azure Container Apps are lacking a few details.

FYI, There are some defaults for existing probe settings which are different between Azure and Terraform, I left them intact.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Enhancement

Related Issue(s)

Fixes #25457, fixes #24845

@akmani-w
Copy link

👍

@SpartakusMd
Copy link
Contributor Author

Is there anything there I could do to unblock the review on this PR?

@SpartakusMd SpartakusMd changed the title azurerm_container_app - additional settings in probes azurerm_container_app - adding missing settings in probes Jul 19, 2024
@SpartakusMd
Copy link
Contributor Author

@jackofallops can I help with anything for the review of the PR?

@SpartakusMd
Copy link
Contributor Author

@katbyte could you take a look and review this PR?

@SpartakusMd SpartakusMd marked this pull request as draft August 14, 2024 14:19
@SpartakusMd SpartakusMd marked this pull request as ready for review August 14, 2024 14:19
@SpartakusMd SpartakusMd force-pushed the feature/Support-for-additional-settings-in-container-apps-probes branch from 4756d4e to 1763213 Compare August 14, 2024 14:27
@SpartakusMd SpartakusMd changed the title azurerm_container_app - adding missing settings in probes azurerm_container_app - Support for additional settings in liveness_probe, startup_probe and readiness_probe Aug 27, 2024
@SpartakusMd
Copy link
Contributor Author

@katbyte @jackofallops how can I help move the PR forward?

@michielpeeters
Copy link

I'm exactly missing these properties! How can I help to move this PR forward :-) and how long will it take that it is available for public?

@SpartakusMd SpartakusMd force-pushed the feature/Support-for-additional-settings-in-container-apps-probes branch from 1763213 to ce30625 Compare September 23, 2024 12:48
@SpartakusMd SpartakusMd closed this Oct 2, 2024
@johschmidt42
Copy link

This has been closed but not merged? Why?

@RomanKreisel
Copy link

This has been closed but not merged? Why?

I was wondering as well. Some comment in here would've been nice.

I think it was maybe replaced by #27551 ?

@SpartakusMd
Copy link
Contributor Author

SpartakusMd commented Oct 9, 2024

I have recreated it in order to maybe attract some attention to it as it went down in the list and no one reviewed it.

Copy link

github-actions bot commented Nov 9, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants