-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_container_app
- Support for additional settings in liveness_probe, startup_probe and readiness_probe
#26573
Conversation
👍 |
Is there anything there I could do to unblock the review on this PR? |
azurerm_container_app
- additional settings in probesazurerm_container_app
- adding missing settings in probes
@jackofallops can I help with anything for the review of the PR? |
@katbyte could you take a look and review this PR? |
4756d4e
to
1763213
Compare
azurerm_container_app
- adding missing settings in probesazurerm_container_app
- Support for additional settings in liveness_probe, startup_probe and readiness_probe
@katbyte @jackofallops how can I help move the PR forward? |
I'm exactly missing these properties! How can I help to move this PR forward :-) and how long will it take that it is available for public? |
… startup_probe and readiness_probe hashicorp#25457
1763213
to
ce30625
Compare
This has been closed but not merged? Why? |
I was wondering as well. Some comment in here would've been nice. I think it was maybe replaced by #27551 ? |
I have recreated it in order to maybe attract some attention to it as it went down in the list and no one reviewed it. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
The available settings for the configuration of the liveness, readiness and startup probes in Azure Container Apps are lacking a few details.
FYI, There are some defaults for existing probe settings which are different between Azure and Terraform, I left them intact.
PR Checklist
Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_container_app
- additional settings in liveness_probe, startup_probe and readiness_probe [Support for additional settings in liveness_probe, startup_probe and readiness_probe #25457]This is a (please select all that apply):
Related Issue(s)
Fixes #25457, fixes #24845