`compute` - update several resources to use `go-azure-sdk` #25533

stephybun · 2024-04-08T14:37:02Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Following resources have been updated to use hashicorp/go-azure-sdk

azurerm_linux_virtual_machine
azurerm_linux_virtual_machine_scale_set
azurerm_orchestrated_machine_scale_set
azurerm_virtual_machine_scale_set
azurerm_windows_virtual_machine
azurerm_windows_virtual_machine_scale_set

Following data sources have been updated to use hashicorp/go-azure-sdk

azurerm_virtual_machine
azurerm_virtual_machine_scale_set

In addition:

Swapped all references to utils.String/Bool/... to pointer.To
Moved the SSHKey diff suppress func to the suppress package

Testing

2 of the failing tests have been fixed by the last commit 1a60a6f

The remaining 9 failing tests are flaky and failing because of an unstable connection from TC with the following error: HTTP response was nil; connection may have been reset but have passed on previous runs.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

…o state

tombuildsstuff

hey @stephybun

Thanks for this PR.

I've taken a look through and left some comments inline, but we'll want to set the Option when retrieving the VM/VMSS from the API to ensure the UserData field is returned/populated in the API response, which'll mean we can track changes to this field and thus remove the "ignores" on the tests - but once that's done we should be able to take another look here and get this one in 👍

Thanks!

internal/services/compute/windows_virtual_machine_resource.go

internal/services/compute/client/client.go

internal/services/compute/linux_virtual_machine_resource.go

katbyte

~~wrong pr~~

wrong pr

tombuildsstuff

One comment but this otherwise LGTM 👍

tombuildsstuff · 2024-04-12T07:38:59Z

internal/services/compute/orchestrated_virtual_machine_scale_set_data_source.go

@@ -133,7 +133,7 @@ func (r OrchestratedVirtualMachineScaleSetDataSource) Attributes() map[string]*p
 			},
 		},

-		"identity": commonschema.SystemAssignedIdentityComputed(),
+		"identity": commonschema.SystemAssignedUserAssignedIdentityComputed(),


can we also update the documentation to reflect this?

The docs appear to be up to date for this? https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/orchestrated_virtual_machine_scale_set#identity

…5581 #25405 #25594 #25533

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.99.0" to "3.100.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.100.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.100.0
ENHANCEMENTS:

* dependencies: updating `hashicorp/go-azure-sdk` to `v0.20240417.1084633` ([#25659](hashicorp/terraform-provider-azurerm#25659 `compute` - update Virtual Machine and Virtual Machine Scale Set resources and data sources to use `hashicorp/go-azure-sdk` ([#25533](hashicorp/terraform-provider-azurerm#25533 `machine_learning` - Add new `machine_learning` block that supports `purge_soft_deleted_workspace_on_destroy` ([#25624](hashicorp/terraform-provider-azurerm#25624 `loganalytics` - update cluster resource to use `hashicorp/go-azure-sdk` ([#23373](hashicorp/terraform-provider-azurerm#23373 Data Source: `azurerm_management_group` - now exports the `tenant_scoped_id` attribute ([#25555](hashicorp/terraform-provider-azurerm#25555 `azurerm_container_app` - the `ingress.ip_security_restriction.ip_address_range` property will now accept an IP address as valid input ([#25609](hashicorp/terraform-provider-azurerm#25609 `azurerm_container_group` - the `identity` block can now be updated ([#25543](hashicorp/terraform-provider-azurerm#25543 `azurerm_express_route_connection` - support for the `private_link_fast_path_enabled` property ([#25596](hashicorp/terraform-provider-azurerm#25596 `azurerm_hdinsight_hadoop_cluster` - support for the `private_link_configuration` block ([#25629](hashicorp/terraform-provider-azurerm#25629 `azurerm_hdinsight_hbase_cluster` - support for the `private_link_configuration` block ([#25629](hashicorp/terraform-provider-azurerm#25629 `azurerm_hdinsight_interactive_query_cluster` - support for the `private_link_configuration` block ([#25629](hashicorp/terraform-provider-azurerm#25629 `azurerm_hdinsight_kafka_cluster` - support for the `private_link_configuration` block ([#25629](hashicorp/terraform-provider-azurerm#25629 `azurerm_hdinsight_spark_cluster` - support for the `private_link_configuration` block ([#25629](hashicorp/terraform-provider-azurerm#25629 `azurerm_management_group` - now exports the `tenant_scoped_id` attribute ([#25555](hashicorp/terraform-provider-azurerm#25555 `azurerm_monitor_activity_log_alert` - support for the `location` property ([#25389](hashicorp/terraform-provider-azurerm#25389 `azurerm_mysql_flexible_server` - update validating regex for `sku_name` ([#25642](hashicorp/terraform-provider-azurerm#25642 `azurerm_postgresql_flexible_server` - support for the `GeoRestore` `create_mode` ([#25664](hashicorp/terraform-provider-azurerm#25664 `azurerm_virtual_network_gateway_connection` - support for the `private_link_fast_path_enabled` property ([#25650](hashicorp/terraform-provider-azurerm#25650 `azurerm_windows_web_app` - support for the `handler_mapping` block ([#25631](hashicorp/terraform-provider-azurerm#25631 `azurerm_windows_web_app_slot` - support for the `handler_mapping` block ([#25631](https://github.com/hashicorp/terraform-provider-azurerm/issues/25631))

BUG FIXES:

* storage: prevent a bug causing the second storage account key to be used for authentication instead of the first ([#25652](hashicorp/terraform-provider-azurerm#25652 `azurerm_active_directory_domain_service` - prevent an issue where `filtered_sync_enabled` was not being updated ([#25594](hashicorp/terraform-provider-azurerm#25594 `azurerm_application_insights` - add a state migration to fix the resource ID casing of Application Insights resources ([#25628](hashicorp/terraform-provider-azurerm#25628 `azurerm_function_app_hybrid_connection` - can now use relay resources created in a different resource group ([#25541](hashicorp/terraform-provider-azurerm#25541 `azurerm_kubernetes_cluster_node_pool` - prevent plan diff when the `windows_profile.outbound_nat_enabled` property is unset ([#25644](hashicorp/terraform-provider-azurerm#25644 `azurerm_machine_learning_compute_cluster` - fix location to point to parent resource for computes ([#25643](hashicorp/terraform-provider-azurerm#25643 `azurerm_machine_learning_compute_instance` - fix location to point to parent resource for computes ([#25643](hashicorp/terraform-provider-azurerm#25643 `azurerm_storage_account` - check replication type when evaluating support level for shares and queues for V1 storage accounts ([#25581](hashicorp/terraform-provider-azurerm#25581 `azurerm_storage_account` - added a sanity check for `dns_endpoint_type` and `blob_properties.restore_policy` ([#25450](hashicorp/terraform-provider-azurerm#25450 `azurerm_web_app_hybrid_connection` - can now use relay resources created in a different resource group ([#25541](hashicorp/terraform-provider-azurerm#25541 `azurerm_windows_web_app` - prevent removal of `site_config.application_stack.node_version` when `app_settings` are updated ([#25488](hashicorp/terraform-provider-azurerm#25488 `azurerm_windows_web_app_slot` - prevent removal of `site_config.application_stack.node_version` when `app_settings` are updated ([#25489](https://github.com/hashicorp/terraform-provider-azurerm/issues/25489))

DEPRECATIONS:

* `logz` - the Logz resources are deprecated and will be removed in v4.0 of the AzureRM Provider since the API no longer allows new instances to be created ([#25405](hashicorp/terraform-provider-azurerm#25405 `azurerm_machine_learning_compute_instance` - marked the `location` field as deprecated in v4.0 of the provider ([#25643](hashicorp/terraform-provider-azurerm#25643 `azurerm_kubernetes_cluster` - the following properties have been deprecated since the API no longer supports cluster creation with legacy Azure Entra integration: `client_app_id`, `server_app_id`, `server_app_secret` and `managed` ([#25200](https://github.com/hashicorp/terraform-provider-azurerm/issues/25200))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/117/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>

github-actions · 2024-05-16T02:10:01Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added dependencies service/storage size/XL labels Apr 8, 2024

stephybun marked this pull request as draft April 8, 2024 14:37

github-actions bot added waiting-response and removed waiting-response labels Apr 8, 2024

stephybun mentioned this pull request Apr 9, 2024

sdk/client/resourcemanager - create poller with status code 200 in response hashicorp/go-azure-sdk#959

Merged

stephybun added 7 commits April 9, 2024 14:14

switch platform image data source and being switching virtual machine

a5092b2

begin using go-azure-sdk for linux virtual machine scale set

08b57a7

update vm and vmss resources to use go-azure-sdk

55c810a

remove deprecated usage of setting response ID as the resource ID int…

08bfa73

…o state

lint

5a3a88d

tflint

2b16dd0

various fixes

8900fdc

stephybun force-pushed the r/swap-virtual-machine-go-azure-sdk branch from 72d4265 to 8900fdc Compare April 9, 2024 13:52

github-actions bot added the waiting-response label Apr 9, 2024

parse image ID before setting into state

ac6524e

github-actions bot removed the waiting-response label Apr 9, 2024

various test fixes

0b6d938

stephybun marked this pull request as ready for review April 10, 2024 08:02

stephybun requested a review from a team April 10, 2024 08:02

stephybun added 2 commits April 10, 2024 13:43

further fixes

46173dd

add deadline to cancel rolling upgrades test

1a60a6f

tombuildsstuff suggested changes Apr 11, 2024

View reviewed changes

github-actions bot added the waiting-response label Apr 11, 2024

katbyte previously approved these changes Apr 11, 2024

View reviewed changes

review comments

f2ae155

github-actions bot removed the waiting-response label Apr 12, 2024

stephybun requested a review from tombuildsstuff April 12, 2024 06:43

tombuildsstuff approved these changes Apr 12, 2024

View reviewed changes

add back comment on identity for orchestrated vmss

bd92297

stephybun added service/virtual-machine service/vmss Virtual Machine Scale Sets labels Apr 12, 2024

stephybun merged commit fdf48b6 into main Apr 15, 2024
29 checks passed

stephybun deleted the r/swap-virtual-machine-go-azure-sdk branch April 15, 2024 05:20

github-actions bot added this to the v3.100.0 milestone Apr 15, 2024

stephybun added a commit that referenced this pull request Apr 16, 2024

Update for #25389 #25596 #25628 #25609 #25450 #25541 #25200 #25543 #2…

ffd0273

…5581 #25405 #25594 #25533

github-actions bot locked as resolved and limited conversation to collaborators May 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`compute` - update several resources to use `go-azure-sdk` #25533

`compute` - update several resources to use `go-azure-sdk` #25533

stephybun commented Apr 8, 2024 •

edited

Loading

tombuildsstuff left a comment

katbyte left a comment •

edited

Loading

tombuildsstuff left a comment

tombuildsstuff Apr 12, 2024

stephybun Apr 12, 2024 •

edited

Loading

github-actions bot commented May 16, 2024

compute - update several resources to use go-azure-sdk #25533

compute - update several resources to use go-azure-sdk #25533

Conversation

stephybun commented Apr 8, 2024 • edited Loading

Community Note

Description

Testing

Change Log

Related Issue(s)

tombuildsstuff left a comment

Choose a reason for hiding this comment

katbyte left a comment • edited Loading

Choose a reason for hiding this comment

tombuildsstuff left a comment

Choose a reason for hiding this comment

tombuildsstuff Apr 12, 2024

Choose a reason for hiding this comment

stephybun Apr 12, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented May 16, 2024

`compute` - update several resources to use `go-azure-sdk` #25533

`compute` - update several resources to use `go-azure-sdk` #25533

stephybun commented Apr 8, 2024 •

edited

Loading

katbyte left a comment •

edited

Loading

stephybun Apr 12, 2024 •

edited

Loading