azurerm_container_app_job - Add Identity property to Container App Job Scaling Rules

[Dionmm]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

In Azure Container App Jobs they have recently added support for authenticating using a managed identity in scaling rules. This allows rules to be added without the need for less secure methods (such as PATs, SAS tokens, or connection strings) to be used for the scaling rules' authentication.

Either user assigned or system identities can be used.

All scaling rules should have an identity property that accepts the resource ID for a user assigned identity or system in the case of a system assigned identity.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.

Some tests appear to be failing on the main branch when running locally, specifically TestAccContainerAppJob_withWorkloadProfileUpdate

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_container_app_job - add support for Managed Identity in scaling rules

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #26570
Related #26994

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[ghjklw]

@Dionmm thank you, I'm looking forward to using it! Is it correct that you have implemented managed identity for scale rules both for azurerm_container_app and azurerm_container_app_job?

It looks like you have only updated the documentation for azurerm_container_app_job.

[Dionmm]

@ghjklw This only implements it for the azurerm_container_app_job resource. I kept PRs small intentionly to comply with the Contributor Guidelines, so planned to do container apps as a separate PR, however, the turn around has been a lot longer than expected. To complete the container apps implementation a separate PR is required to update the API version in the container apps resource to 2024-02-02-preview, and then a follow up PR for the actual implementation and docs. Again, I thought submitting multiple, smaller PRs was more sensible here, but the time to merge each PR has been longer than I expected.

[katbyte]

could we use one of the common schema identity functions here? ie

"identity": commonschema.UserAssignedIdentityOptional(),

[github-actions]

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!