Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Adding sweeper for Resource Groups #296

Merged
merged 4 commits into from
Nov 2, 2017

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Aug 31, 2017

No description provided.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this! :)

@tombuildsstuff
Copy link
Contributor

Just to comment that we're holding off merging this due to a subscription-related issue (which I'm trying to work through) - it's otherwise good to go.

@tombuildsstuff
Copy link
Contributor

Hey @stack72

Thanks for this PR - apologies for the time it's spent waiting.

I spent yesterday sorting out the subscription so that we should be able to merge this - previously this would have caused all of the acceptance tests to fail due to the sweepers failing due to a few locked resources; but I've isolated the resources which were causing the issues and we should be able to merge this now :)

Thanks!

@tombuildsstuff tombuildsstuff merged commit f084b27 into hashicorp:master Nov 2, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants