google_bigtable_instance - deprecate instance_type (#3972) (#2477)

Signed-off-by: Modular Magician <magic-modules@google.com>
hashicorp · Sep 11, 2020 · fa1d4de · fa1d4de
1 parent b0dd62c
commit fa1d4de
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/.changelog/3972.txt b/.changelog/3972.txt
@@ -0,0 +1,3 @@
+```release-note:deprecation
+bigtable: Deprecated `instance_type` for `google_bigtable_instance` - it is now recommended to leave field unspecified.
+```
diff --git a/google-beta/resource_bigtable_instance.go b/google-beta/resource_bigtable_instance.go
@@ -97,6 +97,7 @@ func resourceBigtableInstance() *schema.Resource {
 				Default:      "PRODUCTION",
 				ValidateFunc: validation.StringInSlice([]string{"DEVELOPMENT", "PRODUCTION"}, false),
 				Description:  `The instance type to create. One of "DEVELOPMENT" or "PRODUCTION". Defaults to "PRODUCTION".`,
+				Deprecated:   `It is recommended to leave this field unspecified since the distinction between "DEVELOPMENT" and "PRODUCTION" instances is going away, and all instances will become "PRODUCTION" instances. This means that new and existing "DEVELOPMENT" instances will be converted to "PRODUCTION" instances. It is recommended for users to use "PRODUCTION" instances in any case, since a 1-node "PRODUCTION" instance is functionally identical to a "DEVELOPMENT" instance, but without the accompanying restrictions.`,
 			},
 
 			"deletion_protection": {

diff --git a/website/docs/r/bigtable_instance.html.markdown b/website/docs/r/bigtable_instance.html.markdown
@@ -79,7 +79,11 @@ See structure below.
 * `project` - (Optional) The ID of the project in which the resource belongs. If it
     is not provided, the provider project is used.
 
-* `instance_type` - (Optional) The instance type to create. One of `"DEVELOPMENT"` or `"PRODUCTION"`. Defaults to `"PRODUCTION"`.
+* `instance_type` - (Optional, Deprecated) The instance type to create. One of `"DEVELOPMENT"` or `"PRODUCTION"`. Defaults to `"PRODUCTION"`.
+    It is recommended to leave this field unspecified since the distinction between `"DEVELOPMENT"` and `"PRODUCTION"` instances is going away,
+    and all instances will become `"PRODUCTION"` instances. This means that new and existing `"DEVELOPMENT"` instances will be converted to
+    `"PRODUCTION"` instances. It is recommended for users to use `"PRODUCTION"` instances in any case, since a 1-node `"PRODUCTION"` instance
+    is functionally identical to a `"DEVELOPMENT"` instance, but without the accompanying restrictions.
 
 * `display_name` - (Optional) The human-readable display name of the Bigtable instance. Defaults to the instance `name`.