Add import support for ssl certificate, http/s proxy and url map

[krotkiewicz]

$ TF_ACC=1 go test ./google -v -run TestAccComputeUrlMap -timeout 120m
=== RUN   TestAccComputeUrlMap_import
=== RUN   TestAccComputeUrlMap_basic
=== RUN   TestAccComputeUrlMap_update_path_matcher
=== RUN   TestAccComputeUrlMap_advanced
=== RUN   TestAccComputeUrlMap_noPathRulesWithUpdate
--- PASS: TestAccComputeUrlMap_basic (69.27s)
--- PASS: TestAccComputeUrlMap_import (72.18s)
--- PASS: TestAccComputeUrlMap_noPathRulesWithUpdate (83.70s)
--- PASS: TestAccComputeUrlMap_update_path_matcher (85.37s)
--- PASS: TestAccComputeUrlMap_advanced (143.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	143.133s

$ TF_ACC=1 go test ./google -v -run TestAccComputeTargetHttp
=== RUN   TestAccComputeTargetHttpProxy_import
=== RUN   TestAccComputeTargetHttpsProxy_import
=== RUN   TestAccComputeTargetHttpProxy_basic
=== RUN   TestAccComputeTargetHttpProxy_update
=== RUN   TestAccComputeTargetHttpsProxy_basic
=== RUN   TestAccComputeTargetHttpsProxy_update
=== RUN   TestAccComputeTargetHttpsProxy_invalidCertificate
--- PASS: TestAccComputeTargetHttpsProxy_invalidCertificate (0.04s)
--- PASS: TestAccComputeTargetHttpProxy_basic (93.05s)
--- PASS: TestAccComputeTargetHttpsProxy_basic (93.94s)
--- PASS: TestAccComputeTargetHttpsProxy_import (95.11s)
--- PASS: TestAccComputeTargetHttpProxy_import (104.19s)
--- PASS: TestAccComputeTargetHttpProxy_update (113.31s)
--- PASS: TestAccComputeTargetHttpsProxy_update (120.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	120.100s

$ TF_ACC=1 go test ./google -v -run TestAccComputeSslCertificate
=== RUN   TestAccComputeSslCertificate_import
=== RUN   TestAccComputeSslCertificate_basic
=== RUN   TestAccComputeSslCertificate_no_name
=== RUN   TestAccComputeSslCertificate_name_prefix
--- PASS: TestAccComputeSslCertificate_name_prefix (23.85s)
--- PASS: TestAccComputeSslCertificate_import (23.89s)
--- PASS: TestAccComputeSslCertificate_basic (25.72s)
--- PASS: TestAccComputeSslCertificate_no_name (30.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	30.912s

[krotkiewicz]

@danawillow would you mind reviewing this PR ? should I create corresponding issues ?

[rosbo]

No need to create corresponding issues. We already have one for adding import functionality to compute resources #182

[krotkiewicz]

Hello @rosbo
Is there anything I can do to get this PR approved faster ?

[rosbo]

This is a breaking change. It changes the behavior for host_rule, path_matcher and test.

In the old behavior, if you had some entries created from outside Terraform, it would not create a diff. Now, it would show a diff. For proper import support however, I know this is required.

To be honest, it is probably a good thing. Better to manage everything in Terraform. However, since it is changing the behavior, we will need to wait longer before we release it. We do frequent release of non-breaking changes. And longer cycle (we wait until we have a few breaking changes) before doing a release with breaking changes. We do this to avoid the pain to our users of having to deal constantly with breaking changes requiring them to update their config.

The other 3 resources are good to go. Can you put the url map in a separate PR? I will merge the other 3 resources and then we will merge the url map separately when we are ready to do a breaking change release.

Thank you

[rosbo]

Thank you Konrad for adding import support for all these resources! :)

[krotkiewicz]

@rosbo I removed this breaking change but the importer can't import these 3 properties - so I ignored them in the test.

This way we have half of the import done and we are backward compatible.

The url map part is here #710, I will rebase it after merging this PR.

[rosbo]

Thank you!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!