Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full import support for url map #710

Closed
wants to merge 1 commit into from

Conversation

krotkiewicz
Copy link
Contributor

@krotkiewicz krotkiewicz commented Nov 9, 2017

Fixes part of #182

$ TF_ACC=1 go test ./google -v -run TestAccComputeUrlMap -timeout 120m
=== RUN   TestAccComputeUrlMap_import
=== RUN   TestAccComputeUrlMap_basic
=== RUN   TestAccComputeUrlMap_update_path_matcher
=== RUN   TestAccComputeUrlMap_advanced
=== RUN   TestAccComputeUrlMap_noPathRulesWithUpdate
--- PASS: TestAccComputeUrlMap_basic (69.27s)
--- PASS: TestAccComputeUrlMap_import (72.18s)
--- PASS: TestAccComputeUrlMap_noPathRulesWithUpdate (83.70s)
--- PASS: TestAccComputeUrlMap_update_path_matcher (85.37s)
--- PASS: TestAccComputeUrlMap_advanced (143.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	143.133s

@krotkiewicz
Copy link
Contributor Author

@rosbo PR is rebased.
Does it mean that we have to wait for 2.0.0 version ? How long it could take ?

Thank you

@rosbo rosbo changed the title Add import support for url map Add full import support for url map Nov 13, 2017
@rosbo
Copy link
Contributor

rosbo commented Nov 13, 2017

Thanks for rebasing!

Yes, we will wait for 2.0.0 before merging this breaking change. We already have a few breaking changes lined up but we don't have committed to any timeline yet.

@rosbo rosbo self-assigned this Nov 15, 2017
@paddycarver paddycarver modified the milestone: 2.0.0 Sep 30, 2018
@rileykarson
Copy link
Collaborator

Hey @krotkiewicz! This is awesome work, and you did a great job with it. I'm going to close this PR out in favour of #2245 though, as we've been able to move google_compute_url_map in to Magic Modules, our code generator.

@ghost
Copy link

ghost commented Nov 16, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants