This repository has been archived by the owner on Oct 9, 2020. It is now read-only.
fix(gcp): suppress private key diff to avoid updates #10
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you run terraform apply after creating a gcp resource, we were trying to update the `private_key` when it is a sensitive element and the Lacework server, for security reasons, doesn't return that secret, which means that the resource was always different. We are adding a suppression to avoid updating the resource. Closes #4 Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
ghost
added
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you run terraform apply after creating a gcp resource, we were
trying to update the
private_keywhen it is a sensitive element andthe Lacework server, for security reasons, doesn't return that secret,
which means that the resource was always different.
We are adding a suppression to avoid updating the resource.
Closes #4
Signed-off-by: Salim Afiune Maya afiune@lacework.net