This repository has been archived by the owner on Oct 9, 2020. It is now read-only.
fix(gcp): detect a change of credentials #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
ghost
added
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we tried to fix an issue by avoiding triggering a state change if the
private_keywas different (#10) this suppression made it so that we never send the value to any request
and therefore, having consistent
500 Schema Validationerrors.This change is fixing this issue by checking if there is a change in any of the "known values
that the server will return" then do NOT suppress the diff, but suppress it otherwise.
Signed-off-by: Salim Afiune Maya afiune@lacework.net