Update Vendored Vault Dependency to 1.1.x

[lawliet89]

I was trying to implement some new features for Vault 1.0 but I realised that the vendored Vault dependency is at 0.11.1 (!!!).

I tried taking a stab at this and I managed to build Vault but I am running into some nasty error running tests where Vault would report

2019-03-01T10:10:02.275+0800 [DEBUG] core: non-timeout error accepting on cluster port: error="accept tcp 127.0.0.1:8201: accept4: too many open files"

and the tests never complete running. Somewhere along the way, some misbehaving dependency might be causing this.

I am new to Go and I have no clue how to get govendor to update Vault and all of its transitive dependencies. Could I get some help on this please?

@tyrannosaurus-becks

[cvbarros]

Resolved via #292

[lawliet89]

It's not resolved by that. The vendored libraries were not updated.

[cvbarros]

Thats correct, just confirmed vendored dependency to 0.11. Got mistaken because I actually run the tests against 1.0.3 container and they work 🤷‍♂️

[lawliet89]

It works because most of the secret engines and auth engines configuration are done with generic writes and reads. Some of the /sys endpoints have direct support in the library beyond just generic reads and writes. I wanted to update the resource mounting auth backends but I didn't want to reimplement what was already present in the library using just the generic write methods.

…

On Sat, 16 Mar 2019, 06:37 Carlos Vitor Barros, ***@***.***> wrote: Thats correct, just confirmed vendored dependency to 0.11. Got mistaken because I actually run the tests against 1.0.3 container and they work 🤷‍♂️ — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#333 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA8APeiMqhwSD9VPN49i7HpZ0MGHFhFiks5vXCC4gaJpZM4bYH8A> .

[cvbarros]

Better wait for #356 , it will make it a lot easier to manage dependencies moving forward.

[lawliet89]

With the switch to go modules it's slightly easier to do this probably.

In any case, I tried to upgrade to v1.1.2 go get github.com/hashicorp/vault@v1.1.2 and I am getting

build github.com/terraform-providers/terraform-provider-vault: cannot load github.com/hashicorp/vault/api: ambiguous import: found github.com/hashicorp/vault/api in multiple modules:
	github.com/hashicorp/vault v1.1.2 (/home/yongwen/go/pkg/mod/github.com/hashicorp/vault@v1.1.2/api)
	github.com/hashicorp/vault/api v1.0.1 (/home/yongwen/go/pkg/mod/github.com/hashicorp/vault/api@v1.0.1)

Is @tyrannosaurus-becks able to provide any advice for this?