[MODULES] Switch to Go Modules #356
Conversation
ghost
added
the
There was a problem hiding this comment.
Looks like we'll need to investigate that one test failure 🤔
=== RUN TestAccIdentityGroupExternal
--- FAIL: TestAccIdentityGroupExternal (0.09s)
testing.go:519: Step 1, no error received, but expected a match to:
cannot set 'member_entity_ids' on external groups
|
@radeksimko yes this was peculiar, only hunch I had was this attribute uses a diffsuppressfunc and we upgraded from tf 0.10 to tf 0.11 |
|
I can't even understand how this test would pass, the code on Edit: I think that now it's safe to remove the test since 909c5bd |
|
would like to see this PR merged soon - nice job! |
|
@terraform-providers/vault Could you please confirm it is safe to remove that test and/or raise a separate PR to remove it? |
|
Can this wait until Vault switches? |
provider: Run go fix provider: Run go fmt provider: Encode go version 1.11.5 to .go-version file
run go mod tidy remove govendor from makefile and travis config set appropriate env vars for go modules
had to update transitive cloud.google.com/go to fix errors
appilon
force-pushed
the
go-modules-2019-03-14
branch
from
a9db8ca to
1626014
Compare
|
The tests pass now! |
There was a problem hiding this comment.
Copying what I sent on Slack:
The switch wasn't done with Go 1.12 although we've found lots of bugs with gomod in Go 1.11. The PR is so big that even on my beefy desktop I can't get it to scroll without huge delays, which makes it pretty impossible to review, so reducing scope would be nice. Also this combines a lot of code changes with the gomodules switch which makes it hard to understand what's going on.
I think this PR needs to be split into separate steps. One: update existing deps with govendor and fix code breakages. Two: Switch to go mod. Three: Update vendor folder.
|
I will close this PR and open one just bumping the tf sdk |
Closes #293