-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: Add IAMGroupMembership resource #2273
Conversation
bare bones implementation of a Group Membership resource
@graycoder @ctiwald take a look and let me know |
@@ -89,6 +89,10 @@ | |||
<a href="/docs/providers/aws/r/iam_group_policy.html">aws_iam_group_policy</a> | |||
</li> | |||
|
|||
<li<%= sidebar_current("docs-aws-resource-iam-group-membership") %>> | |||
<a href="/docs/providers/aws/r/iam_group_membership.html">aws_iam_group_membership</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a file here? Can't find the page this links to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
derp, added
LGTM. Thanks for the great feature add @catsby. |
return err | ||
} | ||
|
||
d.SetId("") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema.Resource
code handles the clearing of ID for you on successful return from a Delete
func.
@clint: this makes sense to me - nit on the helper method name but i'm good to merge as-is. LGTM! |
provider/aws: Add IAMGroupMembership resource
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Bare bones implementation of a Group Membership resource
group
anduser
Syntax:
Remaining:
update
method