Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add IAMGroupMembership resource #2273

Merged
merged 6 commits into from
Jun 9, 2015

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Jun 8, 2015

Bare bones implementation of a Group Membership resource

  • 1:1 mapping of group and user

Syntax:

resource "aws_iam_group_association" "dev" {
    name = "dev"
    users = [
        "${aws_iam_user.dev1.name}",
        "${aws_iam_user.dev2.name}",
        ...
    ]
    group = "${aws_iam_group.dev.name}"
}

Remaining:

  • update method
  • docs

bare bones implementation of a Group Membership resource
@catsby
Copy link
Contributor Author

catsby commented Jun 8, 2015

#2274 points out that I didn't bother giving this resource a name attribute, which I should... done in 96a28a0

@catsby
Copy link
Contributor Author

catsby commented Jun 8, 2015

@graycoder @ctiwald take a look and let me know

@@ -89,6 +89,10 @@
<a href="/docs/providers/aws/r/iam_group_policy.html">aws_iam_group_policy</a>
</li>

<li<%= sidebar_current("docs-aws-resource-iam-group-membership") %>>
<a href="/docs/providers/aws/r/iam_group_membership.html">aws_iam_group_membership</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a file here? Can't find the page this links to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

derp, added

@ctiwald
Copy link
Contributor

ctiwald commented Jun 8, 2015

LGTM. Thanks for the great feature add @catsby.

return err
}

d.SetId("")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema.Resource code handles the clearing of ID for you on successful return from a Delete func.

@phinze
Copy link
Contributor

phinze commented Jun 9, 2015

@clint: this makes sense to me - nit on the helper method name but i'm good to merge as-is. LGTM!

catsby added a commit that referenced this pull request Jun 9, 2015
provider/aws: Add IAMGroupMembership resource
@catsby catsby merged commit 05e06d4 into master Jun 9, 2015
@catsby catsby deleted the f-aws-iam-group-membership branch June 9, 2015 14:42
@ghost
Copy link

ghost commented May 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants