Add resource "aws_iam_policy_attachment" to attach a managed policy to users, roles, or groups #2395
Conversation
|
👍 thanks a lot @graycoder |
|
👍 |
|
@catsby anyone from hashicorp able to review this? This is a feature we really need as well, so we're grabbing this branch to play with. |
| roles := expandStringList(d.Get("roles").(*schema.Set).List()) | ||
| groups := expandStringList(d.Get("groups").(*schema.Set).List()) | ||
|
|
||
| if users == nil && roles == nil && groups == nil { |
There was a problem hiding this comment.
The method expandStringList calls make([]*string, ...) and returns the result. Even that slice is empty, it's not nil, so this block will never evaluate to true, yeah?
|
Some nit-picks, otherwise seems good 👍 |
|
I believe I took care of all the concerns, but please let me know if anyone sees anything else 😺 |
|
Thanks @graycoder , this looks good to me |
Add resource "aws_iam_policy_attachment" to attach a managed policy to users, roles, or groups
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This implements #2100
It follows similar logic as #2273
It attaches a managed policy to users, roles, and/or groups.