provider/aws Add support for WAF Regional

[neildothunter]

This is a straight copy of the current Terraform WAF resources (tests and docs) amended to use the WAF Regional API (the resulting WAF resources can then be associated with an Application Load Balancer in that region). As such it contains the same bugs as the current WAF resources.

WAF Regional endpoints (http://docs.aws.amazon.com/general/latest/gr/rande.html#waf_region ) are only available in us-east-1, us-west-2, eu-west-1 and ap-northeast-1. There is nothing here to provide early warning that the region may not support wafregional.

Use aws_wafregional_* resources in addition to aws_waf_* follows the pattern set by the API, but doesn't feel "completely right".

[neildothunter]

looks like my branch is out of step. Is this something i need to fix?

[neildothunter]

aws_wafregional_web_acl_association facilitates link between WAF Regional WebACL and ALB. Fixes #10713.

[Abrishges]

How can I associate my alb with WAF ACL?

resource "aws_wafregional_web_acl_association" "waf_alb_regional" { ............ }

[neildothunter]

That resource takes a webacl and alb id. The resource documentation is with the PR (https://github.com/neildothunter/terraform/blob/6e81561bde53e8e78baa767ff61b706bde138ab0/website/source/docs/providers/aws/r/wafregional_web_acl_association.html.markdown ). However this PR is getting a little old.

[Abrishges]

@neildothunter : thank you! I think the provider is not supported by terraform yet. I getting the following error.

Errors:

• aws_wafregional_web_acl_association.wafassociation: Provider doesn't support resource: aws_wafregional_web_acl_association

[neildothunter]

This is a Pull Request (a request for this code to be merged into the main Terraform branch at which point it can be cut for a release). It will be closed once/if merged.

Until that point you could for example use the local-exec provisioner to call AWS CLI command http://docs.aws.amazon.com/cli/latest/reference/waf-regional/associate-web-acl.html or a Cloudformation stack or which ever method you use to create resources not supported by Terraform.

[gjobin]

I'm not sure, but I think you must resolve the conflicts before it can be merged.
Nice addition by the way.

[radeksimko]

@neildothunter Do you mind if we close this PR in favour of these?

• provider/aws: AWS WAF Regional IPSet + ByteMatchSet support #13705
• [WIP] provider/aws: AWS WAF Regional SizeConstraintSet support #13707
• [WIP] provider/aws: AWS WAF Regional SqlInjectionMatchSet support #13708
• [WIP] provider/aws: AWS WAF Regional XssMatchSet support #13709
• [WIP] provider/aws: AWS WAF Regional Rule support  #13710
• [WIP] provider/aws: AWS WAF Regional Web ACL support #13711
• [WIP] provider/aws: AWS WAF Regional Web ACL Association support #13712

[neildothunter]

Sure. There will be other opportunities to make the contributor list ;)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.