Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] provider/aws: AWS WAF Regional SizeConstraintSet support #13707

Closed

Conversation

yusukegoto
Copy link
Contributor

@yusukegoto yusukegoto commented Apr 17, 2017

This PR is from #13676.

test

resource "aws_wafregional_size_constraint_set" "size_constraint_set" {
  name = "tfsize_constraints"
  size_constraints {
    text_transformation = "NONE"
    comparison_operator = "EQ"
    size = "4096"
    field_to_match {
      type = "BODY"
    }
  }
}

exec

aws_wafregional_size_constraint_set.size_constraint_set: Creating...
  name:                                                      "" => "tfsize_constraints"
  size_constraints.#:                                        "" => "1"
  size_constraints.2029852522.comparison_operator:           "" => "EQ"
  size_constraints.2029852522.field_to_match.#:              "" => "1"
  size_constraints.2029852522.field_to_match.281401076.data: "" => ""
  size_constraints.2029852522.field_to_match.281401076.type: "" => "BODY"
  size_constraints.2029852522.size:                          "" => "4096"
  size_constraints.2029852522.text_transformation:           "" => "NONE"
aws_wafregional_size_constraint_set.size_constraint_set: Creation complete (ID: e45b7c9c-1806-4170-9cff-770ece99a388)

@yusukegoto yusukegoto changed the title providor/aws: AWS WAF Regional SizeConstraintSet support provider/aws: AWS WAF Regional SizeConstraintSet support Apr 23, 2017
@yusukegoto yusukegoto changed the title provider/aws: AWS WAF Regional SizeConstraintSet support [WIP] provider/aws: AWS WAF Regional SizeConstraintSet support May 4, 2017
@yusukegoto yusukegoto force-pushed the wafregional-size-constraint-set branch from 2e5f3a4 to 1a46904 Compare May 4, 2017 09:03
@yusukegoto
Copy link
Contributor Author

yusukegoto commented May 4, 2017

This PR will be rabased after finising #13705.
1a46904 is the true commit.

@DennyLoko
Copy link

Hello @yusukegoto. Since #13705 has already been merged, would you mind to rebase this?

@apparentlymart
Copy link
Contributor

Hello @yusukegoto, and thanks for working on this!

As part of the the Terraform 0.10 release earlier this year, all of the Terraform providers were moved to their own repositories in the terraform-providers GitHub organization, and removed from the Terraform Core repository.

Unfortunately due to the fact that new issues and pull requests are being opened constantly, it was not possible for the various provider maintainers to merge all outstanding pull requests before this split, and there is no automatic way to migrate a pull request to a new repository.

As a result, this pull request can sadly no longer be applied as-is, and so I'm going to close it.

If you or someone else has the time and motivation to apply the same changes to the aws provider repository and open a new PR there, the maintainers of that provider should be able to review and merge it.

Thanks again for working on this, and sorry it was not able to be merged before the provider repository changes.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants