Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/google: fixing the build... #2754

Merged
merged 1 commit into from
Jul 16, 2015
Merged

provider/google: fixing the build... #2754

merged 1 commit into from
Jul 16, 2015

Conversation

svanharmelen
Copy link
Contributor

The v0.beta is removed ( googleapis/google-api-go-client@18450f4), so I also removed it from here. Strangely enough I cannot find any code that actually used it other then in being instantiated in the provider config func.

The v0.beta is removed, so I also removed it from here. Strangely
enough I cannot find any code that actually used it other then in being
instantiated in the provider config func.
@svanharmelen
Copy link
Contributor Author

@sparkprime I noticed you added this one, can you confirm it's OK to remove it again? I don't see it being used anywhere and all test succeed, but just want to be sure 😉

@svanharmelen
Copy link
Contributor Author

@phinze if you could have a look at this one or PR #2757 😃

@sparkprime
Copy link
Contributor

I added for @dcarley, see #2190. Do what you have to do to unbreak the build though (currently on leave and can't follow up why this thing disappeared!)

sparkprime added a commit that referenced this pull request Jul 16, 2015
provider/google: fixing the build...
@sparkprime sparkprime merged commit c8b4d3d into hashicorp:master Jul 16, 2015
@sparkprime
Copy link
Contributor

Perhaps the resource is available in v1 now and it's no-longer needed.

@svanharmelen
Copy link
Contributor Author

@sparkprime thx!

@svanharmelen svanharmelen deleted the b-google branch July 22, 2015 18:56
@ghost
Copy link

ghost commented May 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants