Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skip_requesting_account_id Parameter to S3 Backend #34002

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Add skip_requesting_account_id Parameter to S3 Backend #34002

merged 1 commit into from
Oct 9, 2023

Conversation

knoppiks
Copy link
Contributor

@knoppiks knoppiks commented Oct 6, 2023

As recent (1.6) changes to the s3 backend are breaking for anyone using an s3 api without STS API (like minio), this PR introduces a skip_requesting_account_id param analogously to the aws provider.

Fixes #33983

Target Release

1.6.1

Draft CHANGELOG entry

ENHANCEMENTS

  • Add skip_requesting_account_id param to s3 backend for use with S3 APIs without STS.

@knoppiks
Add skip_requesting_account_id Parameter to S3 Backend
09df221 
Signed-off-by: Jonas Wagner <jwagner@knoppiks.de>
@knoppiks knoppiks requested a review from a team as a code owner October 6, 2023 10:29
@crw crw added enhancement backend/s3 v1.6 Issues (primarily bugs) reported against v1.6 releases labels Oct 6, 2023
@crw
Copy link
Contributor

crw commented Oct 6, 2023

Thanks! I've notified the relevant team.

jar-b
jar-b approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% TF_ACC=1 go test ./internal/backend/remote-state/s3/...
ok      github.com/hashicorp/terraform/internal/backend/remote-state/s3 146.390s

@jar-b jar-b added the 1.6-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Oct 9, 2023
@jar-b jar-b merged commit 9d360ff into hashicorp:main Oct 9, 2023
4 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@teamterraform teamterraform mentioned this pull request Oct 9, 2023
Merged
@jar-b
Copy link
Member

jar-b commented Oct 9, 2023

Thanks for your contribution, @knoppiks!

@jar-b jar-b mentioned this pull request Oct 9, 2023
Merged
@jar-b
Copy link
Member

jar-b commented Oct 9, 2023

This enhancement has been backported and will be released with Terraform v1.6.1.

@logica0419 logica0419 mentioned this pull request Oct 10, 2023
Merged
@12345ieee 12345ieee mentioned this pull request Oct 10, 2023
Closed
@radeksimko radeksimko mentioned this pull request Oct 11, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
1.6-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged backend/s3 enhancement v1.6 Issues (primarily bugs) reported against v1.6 releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terraform ignores skip_credentials_validation flag for s3 backend with custom endpoint.
3 participants
@knoppiks @crw @jar-b