Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Add skip_requesting_account_id Parameter to S3 Backend into v1.6 #34031

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #34002 to be assessed for backporting due to the inclusion of the label 1.6-backport.

The below text is copied from the body of the original PR.


As recent (1.6) changes to the s3 backend are breaking for anyone using an s3 api without STS API (like minio), this PR introduces a skip_requesting_account_id param analogously to the aws provider.

Fixes #33983

Target Release

1.6.1

Draft CHANGELOG entry

ENHANCEMENTS

  • Add skip_requesting_account_id param to s3 backend for use with S3 APIs without STS.

Overview of commits

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

% TF_ACC=1 go test ./internal/backend/remote-state/s3/...
ok      github.com/hashicorp/terraform/internal/backend/remote-state/s3 141.146s

@jar-b jar-b force-pushed the backport/no-sts-s3-backend/only-whole-ghoul branch from 1a0f7ff to 6c25beb Compare October 9, 2023 18:22
@jar-b jar-b merged commit 05d4a23 into v1.6 Oct 9, 2023
4 checks passed
@jar-b jar-b deleted the backport/no-sts-s3-backend/only-whole-ghoul branch October 9, 2023 18:32
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link
Contributor

github-actions bot commented Dec 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants