Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Instance block_device Attribute #440

Merged
merged 3 commits into from
Nov 19, 2014
Merged

AWS Instance block_device Attribute #440

merged 3 commits into from
Nov 19, 2014

Conversation

buth
Copy link
Contributor

@buth buth commented Oct 17, 2014

Added the ability to specify block devices for an AWS instance.

block_device {
  device_name = "/dev/sda"
  volume_type = "gp2"
  volume_size = 500
}

@buth buth mentioned this pull request Oct 17, 2014
@pmoust
Copy link
Contributor

pmoust commented Oct 30, 2014

Cool, needed that, a test would go great with it :)

@buth
Copy link
Contributor Author

buth commented Oct 30, 2014

Can add!

@sethvargo
Copy link
Contributor

@buth as @pmoust said, it would be great to have a test for this 😄

@buth
Copy link
Contributor Author

buth commented Oct 30, 2014

Understood; will code up this afternoon. Thanks for getting back to me!

@buth
Copy link
Contributor Author

buth commented Oct 31, 2014

Added a test; I can also rebase this as another pull request.

There are, however, a few significant caveats due to limitations in goamz. The BlockDevice objects of a described EC2 instance do not include the volume which makes it impossible to test for anything other than existence by device name. This leaves out the size, type, snapshot, and encryption status of the new volume, and eliminates the possibility of testing a block_device attribute meant to overwrite a default setting in an AMI (such as the boot device). Checking manually, all of these features work.

Additionally, I had to use a different AMI from the other tests, one that was EBS-backed.

@spyrospph
Copy link

If the test is ok and all works fine, can you please merge this. It is a well needed feature.

armon added a commit that referenced this pull request Nov 19, 2014
AWS Instance `block_device` Attribute
@armon armon merged commit 4303232 into hashicorp:master Nov 19, 2014
@armon
Copy link
Member

armon commented Nov 19, 2014

Thanks!

@armon armon mentioned this pull request Nov 20, 2014
@ameir ameir mentioned this pull request Jan 23, 2015
@ghost ghost locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants