core: fixing a small logic bug in diffList #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It’s not enough to only check if no new value is set. It can also be that a new value is set, but contains a variable that cannot be interpolated until a depending resource is created during the apply fase. I actually found this one as one of the acceptance tests for the AWS ELB resource was failing. It failed with the following error: ``` --- FAIL: TestAccAWSELB_InstanceAttaching (177.83 seconds) testing.go:121: Step 1 error: Error applying: aws_elb.bar: diffs didn't match during apply. This is a bug with the resource provider, please report a bug. FAIL exit status 1 FAIL github.com/hashicorp/terraform/builtin/providers/aws 177.882s ``` After a quick look I noticed it was actually a bug in core TF so added the test and made sure all unit tests and AWS acceptance tests are now running successfully.
svanharmelen
pushed a commit
that referenced
this pull request
Dec 12, 2014
core: fixing a small logic bug in diffList
| Attributes: map[string]*terraform.ResourceAttrDiff{ | ||
| "internal": &terraform.ResourceAttrDiff{ | ||
| Old: "0", | ||
| New: "1", |
There was a problem hiding this comment.
Does this actually affect the test? It might be simpler to just remove the "internal" part.
There was a problem hiding this comment.
Your right... The 'internal' part can be omitted. In the PR for changing the set behaviour I add two more tests to this file, so will update this test in that same PR...
This was referenced Dec 14, 2014
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s not enough to only check if no new value is set. It can also be that a new value is set, but contains a variable that cannot be interpolated until a depending resource is created during the apply fase.
I actually found this one as one of the acceptance tests for the AWS ELB resource was failing. It failed with the following error:
After a quick look I noticed it was actually a bug in core TF so added the test and made sure all unit tests and AWS acceptance tests are now running successfully.