Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fixing a small logic bug in diffList #661

Merged
merged 1 commit into from
Dec 12, 2014
Merged

core: fixing a small logic bug in diffList #661

merged 1 commit into from
Dec 12, 2014

Commits on Dec 12, 2014

  1. Fixing a small logic bug in diffList

    It’s not enough to only check if no new value is set. It can also be
    that a new value is set, but contains a variable that cannot be
    interpolated until a depending resource is created during the apply
    fase.
    
    I actually found this one as one of the acceptance tests for the AWS
    ELB resource was failing. It failed with the following error:
    
    ```
    --- FAIL: TestAccAWSELB_InstanceAttaching (177.83 seconds)
      testing.go:121: Step 1 error: Error applying: aws_elb.bar: diffs
    didn't match during apply. This is a bug with the resource provider,
    please report a bug.
    FAIL
    exit status 1
    FAIL  github.com/hashicorp/terraform/builtin/providers/aws  177.882s
    ```
    
    After a quick look I noticed it was actually a bug in core TF so added
    the test and made sure all unit tests and AWS acceptance tests are now
    running successfully.
    Sander van Harmelen committed Dec 12, 2014
    Configuration menu
    Copy the full SHA
    54db46e View commit details
    Browse the repository at this point in the history