-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vault Dependency Upgrades [VAULT-871] #10903
Conversation
This manually fixes the version for:
due to: etcd-io/etcd#12569 . It also does not upgrade the version of:
as these remove the |
61238b7
to
530166c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One outstanding comment I don't feel too strongly about. Probably best to have another approver before merging though.
This reverts commit eb74ca6.
* master: Adds API docs for max_age role parameter of JWT/OIDC auth method (#10916) UI/Database Secrets Engine cleanup (#10949) helper/metricsutil: Prevent potential Ticker leak (#10913) core/expiration: Add backoff jitter to the expiration retries (#10937) Revert "Vault Dependency Upgrades [VAULT-871] (#10903)" (#10939) Vault Dependency Upgrades [VAULT-871] (#10903) Add docs for Agent's template_retry option added in #10644, based on those from consul-template configuration. Also fix some existing config docs that weren't adhering to our conventions. (#10911) UI Database Secrets Engine (MongoDB) (#10655) OpenAPI - Don't panic if field isn't found (#10929) Vault-1403 Switch Expiration Manager to use Fairsharing Backpressure (#1709) (#10932) Update KV Secrets Engine index (#10933)
This set of dependency upgrades fixes the known CVEs in our libraries: https://hashicorp.atlassian.net/browse/VAULT-871 . The only dependency not upgraded is
github.com/opencontainers/runc
which I believe is only used in our docker tests. The reason I couldn't upgrade runc is in a comment below.This change is large, but should not be too risky, as the major changes are mostly changes to our testing. There seem to be a few rabbitmq changes as well, that should be tested manually, and vault on windows should also be tested manually due to the winio upgrade.