Vault Dependency Upgrades #10940
Closed
Vault Dependency Upgrades #10940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
February 11, 2021 09:36
| @@ -159,7 +159,7 @@ func decodeBatchRequestItems(src interface{}, dst *[]BatchRequestItem) error { | |||
| } else if casted, ok := v.(string); ok { | |||
| (*dst)[i].Context = casted | |||
| } else { | |||
| errs.Errors = append(errs.Errors, fmt.Sprintf("'[%d].context' expected type 'string', got unconvertible type '%T'", i, item["context"])) | |||
| errs.Errors = append(errs.Errors, fmt.Sprintf("'[%d].context' expected type 'string', got unconvertible type '%T', value: '%v'", i, item["context"], item["context"])) | |||
There was a problem hiding this comment.
How come these changed in this PR? I'm not sure we want to be returning these as errors since they may get logged. Especially the plaintext one below.
There was a problem hiding this comment.
These changed due to the upgrade in the map structure here: https://github.com/mitchellh/mapstructure/blob/07998cfd7ab2f7f7e5ddce402c4edf38317451eb/mapstructure_examples_test.go#L65
calvn
reviewed
Feb 24, 2021
go.mod
Outdated
| github.com/mitchellh/gox v1.0.1 | ||
| github.com/mitchellh/mapstructure v1.3.3 | ||
| github.com/mitchellh/go-testing-interface v1.14.2-0.20210217184823-a52172cd2f64 | ||
| github.com/mitchellh/gox v0.4.0 |
There was a problem hiding this comment.
How come gox got downgraded?
There was a problem hiding this comment.
Good catch -- I think it had something to do with the versioning issue with go-testing-interface, but it was an unnecessary straggler dependency. Upgraded it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same PR as: #10903