Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Add a sentinel error for missing KV secrets into release/1.11.x #16724

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16699 to be assessed for backporting due to the inclusion of the label backport/1.11.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Adding a sentinel error value ErrSecretNotFound. With this change, callers can check specifically for non-existing secrets:

secret, err := client.KvV2("secret").Get("foo")

if errors.Is(err, vault.ErrSecretNotFound) {
    // handle missing secret
}
if err != nil {
    // handle other errors
}

An example where this would be useful is when implementing an "upsert" behavior, as suggested in #16483. The caller can check the error returned from KVv2.Patch for errors.Is(err, vault.ErrSecretNotFound) and call KvV2.Put accordingly.


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/averche/kv-secret-not-found/probably-harmless-cougar branch 2 times, most recently from 676722f to 41fa1e1 Compare August 15, 2022 17:40
@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@averche averche closed this Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants