Fail completed successfully check for failing Enos tests #20335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymalasinha
force-pushed
the
jsinha/enos_strict_check
branch
3 times, most recently
from
2c8ffb1
to
52eb64b
Compare
|
For posterity, here's the upstream bug that Jaymala reported: actions/runner#2566 |
ryancragun
approved these changes
Apr 25, 2023
|
Before you merge this, you should know that pressing cancel (needs permissions to do it) very early can still bypass your because you don't run the failing job if the deps has result |
added 2 commits
April 26, 2023 13:55
…sts fail Signed-off-by: Jaymala Sinha <jaymala@hashicorp.com>
Signed-off-by: Jaymala Sinha <jaymala@hashicorp.com>
jaymalasinha
force-pushed
the
jsinha/enos_strict_check
branch
from
52eb64b
to
fd1332f
Compare
This was referenced Apr 26, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
completed-successfullyrequired status check is now being skipped if any of the dependent jobs fail. This commit is a workaround to force the check and fail the status if any of the dependent jobs fail. If the any of the dependent jobs are skipped the required status check will be skipped as well.