Backport of Fail completed successfully check for failing Enos tests into release/1.12.x #20379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
requested a review
from a team
as a code owner
hc-github-team-secure-vault-core
force-pushed
the
backport/jsinha/enos_strict_check/centrally-blessed-ladybug
branch
from
0f47695
to
ead52f4
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/jsinha/enos_strict_check/centrally-blessed-ladybug
branch
from
31c5895
to
eef7dec
Compare
jaymalasinha
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20335 to be assessed for backporting due to the inclusion of the label backport/1.12.x.
The below text is copied from the body of the original PR.
The
completed-successfullyrequired status check is now being skipped if any of the dependent jobs fail. This commit is a workaround to force the check and fail the status if any of the dependent jobs fail. If the any of the dependent jobs are skipped the required status check will be skipped as well.Overview of commits