Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: fix undefined csv filename #26485

Merged
merged 6 commits into from
Apr 18, 2024

Conversation

hellobontempo
Copy link
Contributor

during the recent client count dashboard refactor the this.formattedStartDate getter was accidentally removed. Test coverage has been added so further regressions in this department will be caught!

before

Screenshot 2024-04-17 at 6 56 30 PM

after

Screenshot 2024-04-17 at 6 56 44 PM

@hellobontempo hellobontempo added ui bug Used to indicate a potential bug backport/1.16.x labels Apr 18, 2024
@hellobontempo hellobontempo added this to the 1.16.2 milestone Apr 18, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 18, 2024
Copy link

github-actions bot commented Apr 18, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

@@ -60,6 +57,11 @@ export default class Attribution extends Component {
return attributionLegend;
}

get formattedStartDate() {
Copy link
Contributor Author

@hellobontempo hellobontempo Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally removed this in this PR 🤦

Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️ intellectual honesty

@hellobontempo hellobontempo merged commit dd939d9 into main Apr 18, 2024
31 checks passed
@hellobontempo hellobontempo deleted the ui/VAULT-26207/fix-csv-file-startdate branch April 18, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants