Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI: fix undefined csv filename into release/1.16.x #26518

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #26485 to be assessed for backporting due to the inclusion of the label backport/1.16.x.

The below text is copied from the body of the original PR.


during the recent client count dashboard refactor the this.formattedStartDate getter was accidentally removed. Test coverage has been added so further regressions in this department will be caught!

before

Screenshot 2024-04-17 at 6 56 30 PM

after

Screenshot 2024-04-17 at 6 56 44 PM
Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/VAULT-26207/fix-csv-file-startdate/remotely-big-sole branch from a753f70 to 63e0d9f Compare April 18, 2024 18:11
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 18, 2024
@hellobontempo hellobontempo added backport and removed hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed labels Apr 18, 2024
@hellobontempo hellobontempo added this to the 1.16.2 milestone Apr 18, 2024
@hellobontempo hellobontempo enabled auto-merge (squash) April 18, 2024 18:12
Copy link

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Apr 18, 2024

CI Results:
All Go tests succeeded! ✅

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 18, 2024
@hellobontempo hellobontempo merged commit 6527bf5 into release/1.16.x Apr 18, 2024
24 checks passed
@hellobontempo hellobontempo deleted the backport/ui/VAULT-26207/fix-csv-file-startdate/remotely-big-sole branch April 18, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants