Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update the page description for SEO improvement #4 #29166

Merged
merged 9 commits into from
Dec 12, 2024

Conversation

yhyakuna
Copy link
Contributor

Description

This PR updates the secrets engine docs title & description for style consistency, as well as SEO improvement.

  • /secrets/identity/identity-token.mdx
  • /secrets/identity/index.mdx
  • /secrets/identity/oidc-provider.mdx
  • /secrets/key-management/awskms.mdx
  • /secrets/key-management/azurekeyvault/index.mdx
  • /secrets/key-management/azurekeyvault/setup.mdx
  • /secrets/key-management/gcpkms/index.mdx
  • /secrets/key-management/gcpkms/setup.mdx
  • /secrets/key-management/index.mdx

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 12, 2024
Copy link

github-actions bot commented Dec 12, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

Co-authored-by: Jonathan Frappier <92055993+jonathanfrappier@users.noreply.github.com>
yhyakuna and others added 3 commits December 12, 2024 08:35
Co-authored-by: Jonathan Frappier <92055993+jonathanfrappier@users.noreply.github.com>
Co-authored-by: Jonathan Frappier <92055993+jonathanfrappier@users.noreply.github.com>
@yhyakuna yhyakuna merged commit c4be16c into main Dec 12, 2024
34 checks passed
@yhyakuna yhyakuna deleted the docs/secrets-seo-updates-4 branch December 12, 2024 17:01
Monkeychip pushed a commit that referenced this pull request Dec 18, 2024
* Update the page description to improve SEO

* Minor updates

* Update setup.mdx

* Update setup.mdx

* Update website/content/docs/secrets/ad/migration-guide.mdx

Co-authored-by: Jonathan Frappier <92055993+jonathanfrappier@users.noreply.github.com>

* Update website/content/docs/secrets/ad/index.mdx

Co-authored-by: Jonathan Frappier <92055993+jonathanfrappier@users.noreply.github.com>

* Update website/content/docs/secrets/ad/index.mdx

Co-authored-by: Jonathan Frappier <92055993+jonathanfrappier@users.noreply.github.com>

---------

Co-authored-by: Jonathan Frappier <92055993+jonathanfrappier@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants