Website: Demo improvements #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, GIF:
|
So great |
jeffwecan
added a commit
to jeffwecan/vault
that referenced
this pull request
Nov 7, 2018
[SRE-432] Install ansible-modules-hashivault in vault role
swatibourai0560
added a commit
to swatibourai0560/vault
that referenced
this pull request
Dec 10, 2024
… role name is consistent. The role name specified in allowed_roles="my-role" under the section "Rootless Configuration and Password Rotation for Static Roles" should align with the static role name in step hashicorp#3. Previously, the command incorrectly used "my-static-role"; it should be "my-role" to match the earlier step. The same role name should also be used when reading the static credentials in step hashicorp#4
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wires in the loading indications, properly handles refocusing inputs and throws the sidebar overlay on the main page when demo is active, as well as a close button.