Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default max_open_connections for db plugins #8262

Merged

Conversation

spangenberg
Copy link
Contributor

#7093 changed the default but didn't update the docs

@spangenberg spangenberg added docs bug Used to indicate a potential bug secret/database labels Jan 30, 2020
@spangenberg spangenberg self-assigned this Jan 30, 2020
@spangenberg spangenberg force-pushed the fix-max-open-connections-docs branch from 47cda82 to 1693826 Compare January 30, 2020 15:43
Copy link
Contributor

@michelvocks michelvocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spangenberg spangenberg merged commit 2989c1d into hashicorp:master Jan 30, 2020
@spangenberg spangenberg deleted the fix-max-open-connections-docs branch January 30, 2020 16:33
catsby added a commit that referenced this pull request Feb 4, 2020
…nto b-fix-mysql-lock-panic

* 'b-fix-mysql-lock-panic' of github.com:hashicorp/vault: (52 commits)
  Fix minor typo in doc string (#8277)
  Update gen_openapi.sh (#8273)
  update dependencies (#8271)
  docs: update vault k8s to 0.2.0 (#8269)
  Fix flaky test of api renewer by moving away from legacy api. (#8265)
  Clean AlibabaCloud physical backend code (#8186)
  Update GH issue template to point to forum (#8226)
  Fix default max_open_connections for db plugins (#8262)
  Fix broken link (#8259)
  Removing timing-dependent aspects of test. (#8261)
  Changelog++
  Added flag to disable X-Vault-Token header proxy if client passes the token (#8101)
  changelog++
  changelog++
  test: fix TestAgent_Template_Basic (#8257)
  docs: fix api path for merge entity identity doc (#8258)
  Bump etcd client API dep (#8037)
  Add Consul TLS options to access API endpoint (#8253)
  Docs: Add nomad TLS options (#8254)
  Update CHANGELOG.md
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug docs secret/database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants