Fix flaky test of api renewer by moving away from legacy api. #8265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
approved these changes
Jan 30, 2020
catsby
added a commit
that referenced
this pull request
Feb 4, 2020
…nto b-fix-mysql-lock-panic * 'b-fix-mysql-lock-panic' of github.com:hashicorp/vault: (52 commits) Fix minor typo in doc string (#8277) Update gen_openapi.sh (#8273) update dependencies (#8271) docs: update vault k8s to 0.2.0 (#8269) Fix flaky test of api renewer by moving away from legacy api. (#8265) Clean AlibabaCloud physical backend code (#8186) Update GH issue template to point to forum (#8226) Fix default max_open_connections for db plugins (#8262) Fix broken link (#8259) Removing timing-dependent aspects of test. (#8261) Changelog++ Added flag to disable X-Vault-Token header proxy if client passes the token (#8101) changelog++ changelog++ test: fix TestAgent_Template_Basic (#8257) docs: fix api path for merge entity identity doc (#8258) Bump etcd client API dep (#8037) Add Consul TLS options to access API endpoint (#8253) Docs: Add nomad TLS options (#8254) Update CHANGELOG.md ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to reproduce this, so it's a speculative fix. An example failure from https://circleci.com/gh/hashicorp/vault/37790?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link looks like
What I think happened is that we renewed successfully at least once, and then due to a slow VM didn't reach https://github.com/hashicorp/vault/blob/master/api/lifetime_watcher.go#L337 (where we'd have exited cleanly) before it encountered a renewal failure here: https://github.com/hashicorp/vault/blob/master/api/lifetime_watcher.go#L286. The newer API doesn't enter that if statement so shouldn't fail this way. I converted the other tests in this file to use the newer API as well because I think it makes more sense to exercise the non-legacy API.