upgrade storybook and babel deps #9371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andaley
commented
Jul 1, 2020
| @@ -4,7 +4,7 @@ import notes from './alert-banner.md'; | |||
| import { withKnobs, object } from '@storybook/addon-knobs'; | |||
| import { MESSAGE_TYPES } from '../addon/helpers/message-types.js'; | |||
|
|
|||
| storiesOf('Alerts/AlertBanner/', module) | |||
There was a problem hiding this comment.
Trailing / in story names are no longer supported, so I had to remove them.
andaley
commented
Jul 1, 2020
| "@ember/optional-features": "^0.7.0", | ||
| "@hashicorp/structure-icons": "^1.3.0", | ||
| "@storybook/ember-cli-storybook": "meirish/ember-cli-storybook#6bd58326d8c21e986d390b541ae5e49089d61b93", | ||
| "@storybook/ember-cli-storybook": "^0.2.1", |
There was a problem hiding this comment.
note that we no longer need to use the forked version of ember-cli-storybook since the updated version includes the bugfix we were waiting for!
andaley
commented
Jul 1, 2020
| @@ -40,9 +40,10 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@babel/plugin-proposal-object-rest-spread": "^7.5.5", | |||
| "@babel/plugin-transform-block-scoping": "^7.10.4", | |||
There was a problem hiding this comment.
this was the missing dependency that caused make static-dist to fail. we can likely remove this after upgrading to Octane.
andaley
commented
Jul 1, 2020
| "@storybook/addons": "^5.1.10", | ||
| "@storybook/ember": "^5.1.10", | ||
| "babel-loader": "^8.0.6", | ||
| "@babel/core": "^7.10.4", |
There was a problem hiding this comment.
i updated the rest of our babel dependencies since we were starting to fall behind anyway.
andaley
pushed a commit
that referenced
this pull request
Jul 1, 2020
andaley
pushed a commit
that referenced
this pull request
Jul 2, 2020
andaley
pushed a commit
that referenced
this pull request
Jul 2, 2020
andaley
pushed a commit
that referenced
this pull request
Jul 2, 2020
andaley
pushed a commit
that referenced
this pull request
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our Storybook and Babel dependencies. Solves #9315.
Testing
Checkout this PR and run
make static-dist. The build should not fail.As an added benefit we'll get all the features of Storybook 5.3, which includes docs & MDX support