Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade storybook and babel deps #9371

Merged
merged 3 commits into from
Jul 1, 2020
Merged

upgrade storybook and babel deps #9371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcad494
upgrade storybook and babel deps
andaley Jul 1, 2020
b68539c
Merge branch 'master' into fix-make-static-dist
Jul 1, 2020
413872d
Merge branch 'master' into fix-make-static-dist
Jul 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ui/.storybook/babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
/* eslint-env node */

module.exports = {
presets: [
[
Expand Down
2 changes: 1 addition & 1 deletion ui/blueprints/story/files/__path__/stories/__name__.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import hbs from 'htmlbars-inline-precompile';
import { storiesOf } from '@storybook/ember';
<%= importMD %>

storiesOf('<%= classifiedModuleName %>/', module)
storiesOf('<%= classifiedModuleName %>', module)
.addParameters({ options: { showPanel: true } })
.add(`<%= classifiedModuleName %>`, () => ({
template: hbs`
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/alert-banner.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import notes from './alert-banner.md';
import { withKnobs, object } from '@storybook/addon-knobs';
import { MESSAGE_TYPES } from '../addon/helpers/message-types.js';

storiesOf('Alerts/AlertBanner/', module)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing / in story names are no longer supported, so I had to remove them.

storiesOf('Alerts/AlertBanner', module)
.addParameters({ options: { showPanel: false } })
.addDecorator(
withKnobs({
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/alert-inline.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { storiesOf } from '@storybook/ember';
import notes from './alert-inline.md';
import { MESSAGE_TYPES } from '../addon/helpers/message-types.js';

storiesOf('Alerts/AlertInline/', module)
storiesOf('Alerts/AlertInline', module)
.addParameters({ options: { showPanel: false } })
.add(
'AlertInline',
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/chevron.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { storiesOf } from '@storybook/ember';
import { withKnobs, select } from '@storybook/addon-knobs';
import notes from './chevron.md';

storiesOf('Chevron/', module)
storiesOf('Chevron', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs())
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/confirm-action.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { storiesOf } from '@storybook/ember';
import { withKnobs, text, boolean } from '@storybook/addon-knobs';
import notes from './confirm-action.md';

storiesOf('ConfirmAction/', module)
storiesOf('Confirm/ConfirmAction', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(
withKnobs({
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/doc-link.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import hbs from 'htmlbars-inline-precompile';
import { storiesOf } from '@storybook/ember';
import notes from './doc-link.md';

storiesOf('DocLink/', module)
storiesOf('DocLink', module)
.addParameters({ options: { showPanel: true } })
.add(
`DocLink`,
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/empty-state.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { storiesOf } from '@storybook/ember';
import { withKnobs, text } from '@storybook/addon-knobs';
import notes from './empty-state.md';

storiesOf('EmptyState/', module)
storiesOf('EmptyState', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs({ escapeHTML: false }))
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/form-field-groups.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const MODELS = {

const DEFAULT_VALUE = 'aws/client';

storiesOf('Form/FormFieldGroups/', module)
storiesOf('Forms/FormFieldGroups', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs())
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/form-field.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const createAttr = (name, type, options) => {
};
};

storiesOf('Form/FormField/', module)
storiesOf('Forms/FormField', module)
.add(
`FormField|string`,
() => ({
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/form-save-buttons.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { storiesOf } from '@storybook/ember';
import { withKnobs, text, boolean } from '@storybook/addon-knobs';
import notes from './form-save-buttons.md';

storiesOf('FormSaveButtons/', module)
storiesOf('Forms/FormSaveButtons', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(
withKnobs({
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/icon.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import notes from './icon.md';
import icons from '../../../node_modules/@hashicorp/structure-icons/dist/index.js';
import { withKnobs, select } from '@storybook/addon-knobs';

storiesOf('Icon/', module)
storiesOf('Icon', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs())
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/info-table-row.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { storiesOf } from '@storybook/ember';
import { withKnobs, boolean, text } from '@storybook/addon-knobs';
import notes from './info-table-row.md';

storiesOf('InfoTableRow/', module)
storiesOf('InfoTable/InfoTableRow', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs({ escapeHTML: false }))
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/info-table.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import notes from './info-table.md';

const ITEMS = ['https://127.0.0.1:8201', 'hello', 3];

storiesOf('InfoTable/', module)
storiesOf('InfoTable/InfoTable', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs({ escapeHTML: false }))
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/layout-loading.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import hbs from 'htmlbars-inline-precompile';
import { storiesOf } from '@storybook/ember';
import notes from './layout-loading.md';

storiesOf('Loading/LayoutLoading/', module)
storiesOf('LayoutLoading', module)
.addParameters({ options: { showPanel: true } })
.add(
`LayoutLoading`,
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/list-view.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ let options = {
filtered,
};

storiesOf('ListView/', module)
storiesOf('ListView', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs())
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/masked-input.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { storiesOf } from '@storybook/ember';
import { withKnobs, text, boolean } from '@storybook/addon-knobs';
import notes from './masked-input.md';

storiesOf('MaskedInput/', module)
storiesOf('MaskedInput', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs())
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/message-error.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ let model = EmberObject.create({
isError: true,
});

storiesOf('MessageError/', module)
storiesOf('MessageError', module)
.addParameters({ options: { showPanel: true } })
.add(
`MessageError`,
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/message.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import hbs from 'htmlbars-inline-precompile';
import { storiesOf } from '@storybook/ember';
import notes from './message.md';

storiesOf('Confirm/Message/', module)
storiesOf('Confirm/Message', module)
.addParameters({ options: { showPanel: true } })
.add(
`Message`,
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/popup-menu.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import hbs from 'htmlbars-inline-precompile';
import { storiesOf } from '@storybook/ember';
import notes from './popup-menu.md';

storiesOf('PopupMenu/', module)
storiesOf('PopupMenu', module)
.addParameters({ options: { showPanel: true } })
.add(
`PopupMenu`,
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/search-select.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { withKnobs, text } from '@storybook/addon-knobs';
const onChange = value => alert(`New value is "${value}"`);
const models = ['identity/groups'];

storiesOf('SearchSelect/', module)
storiesOf('SearchSelect', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs({ escapeHTML: false }))
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/select.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const OPTIONS = [
{ value: 'weds', label: 'Wednesday', spanish: 'miercoles' },
];

storiesOf('Select/', module)
storiesOf('Select', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs())
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/toolbar/toolbar-actions.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { storiesOf } from '@storybook/ember';
import { withKnobs } from '@storybook/addon-knobs';
import notes from './toolbar-actions.md';

storiesOf('Toolbar/', module)
storiesOf('Toolbar', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs())
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/toolbar/toolbar-download-button.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { storiesOf } from '@storybook/ember';
import { withKnobs, text } from '@storybook/addon-knobs';
import notes from './toolbar-download-button.md';

storiesOf('Toolbar/', module)
storiesOf('Toolbar', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs())
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/toolbar/toolbar-filters.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { storiesOf } from '@storybook/ember';
import { withKnobs } from '@storybook/addon-knobs';
import notes from './toolbar-filters.md';

storiesOf('Toolbar/', module)
storiesOf('Toolbar', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs())
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/toolbar/toolbar-link.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { storiesOf } from '@storybook/ember';
import { withKnobs, select, text } from '@storybook/addon-knobs';
import notes from './toolbar-link.md';

storiesOf('Toolbar/', module)
storiesOf('Toolbar', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs())
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/toolbar/toolbar-secret-link.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { storiesOf } from '@storybook/ember';
import { withKnobs, select, text } from '@storybook/addon-knobs';
import notes from './toolbar-secret-link.md';

storiesOf('Toolbar/', module)
storiesOf('Toolbar', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs())
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/toolbar/toolbar.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { storiesOf } from '@storybook/ember';
import { withKnobs, select } from '@storybook/addon-knobs';
import notes from './toolbar.md';

storiesOf('Toolbar/', module)
storiesOf('Toolbar', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs())
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/ttl-picker.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import hbs from 'htmlbars-inline-precompile';
import { storiesOf } from '@storybook/ember';
import notes from './ttl-picker.md';

storiesOf('TTL/TtlPicker/', module)
storiesOf('TTL/TtlPicker', module)
.addParameters({ options: { showPanel: false } })
.add(
`TtlPicker`,
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/ttl-picker2.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { storiesOf } from '@storybook/ember';
import notes from './ttl-picker2.md';
import { withKnobs, text, boolean, select } from '@storybook/addon-knobs';

storiesOf('TTL/TtlPicker2/', module)
storiesOf('TTL/TtlPicker2', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs())
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/core/stories/vault-logo-spinner.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import hbs from 'htmlbars-inline-precompile';
import { storiesOf } from '@storybook/ember';
import notes from './vault-logo-spinner.md';

storiesOf('Loading/VaultLogoSpinner/', module)
storiesOf('VaultLogoSpinner', module)
.addParameters({ options: { showPanel: true } })
.add(
`VaultLogoSpinner`,
Expand Down
23 changes: 12 additions & 11 deletions ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,10 @@
},
"devDependencies": {
"@babel/plugin-proposal-object-rest-spread": "^7.5.5",
"@babel/plugin-transform-block-scoping": "^7.10.4",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the missing dependency that caused make static-dist to fail. we can likely remove this after upgrading to Octane.

"@ember/optional-features": "^0.7.0",
"@hashicorp/structure-icons": "^1.3.0",
"@storybook/ember-cli-storybook": "meirish/ember-cli-storybook#6bd58326d8c21e986d390b541ae5e49089d61b93",
"@storybook/ember-cli-storybook": "^0.2.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that we no longer need to use the forked version of ember-cli-storybook since the updated version includes the bugfix we were waiting for!

"Duration.js": "icholy/Duration.js#golang_compatible",
"autosize": "^4.0.0",
"babel-eslint": "^10.0.2",
Expand All @@ -65,12 +66,12 @@
"deepmerge": "^4.0.0",
"doctoc": "^1.4.0",
"ember-api-actions": "^0.2.8",
"ember-auto-import": "^1.5.3",
"ember-auto-import": "^1.6.0",
"ember-basic-dropdown": "^1.0.0",
"ember-basic-dropdown-hover": "^0.6.0",
"ember-cli": "~3.11.0",
"ember-cli-autoprefixer": "^0.8.1",
"ember-cli-babel": "^7.8.0",
"ember-cli-babel": "^7.21.0",
"ember-cli-browserstack": "^0.0.7",
"ember-cli-clipboard": "^0.13.0",
"ember-cli-content-security-policy": "^1.0.0",
Expand Down Expand Up @@ -143,14 +144,14 @@
"yargs-parser": "^13.1.1"
},
"optionalDependencies": {
"@babel/core": "^7.5.5",
"@storybook/addon-knobs": "^5.1.10",
"@storybook/addon-links": "^5.1.10",
"@storybook/addon-notes": "^5.1.10",
"@storybook/addon-viewport": "^5.1.10",
"@storybook/addons": "^5.1.10",
"@storybook/ember": "^5.1.10",
"babel-loader": "^8.0.6",
"@babel/core": "^7.10.4",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i updated the rest of our babel dependencies since we were starting to fall behind anyway.

"@storybook/addon-knobs": "^5.3.19",
"@storybook/addon-links": "^5.3.19",
"@storybook/addon-notes": "^5.3.19",
"@storybook/addon-viewport": "^5.3.19",
"@storybook/addons": "^5.3.19",
"@storybook/ember": "^5.3.19",
"babel-loader": "^8.1.0",
"jsdoc-to-markdown": "^5.0.0",
"lint-staged": "^10.1.2"
},
Expand Down
2 changes: 1 addition & 1 deletion ui/stories/alert-popup.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { storiesOf } from '@storybook/ember';
import notes from './alert-popup.md';
import { MESSAGE_TYPES } from '../lib/core/addon/helpers/message-types.js';

storiesOf('Alerts/AlertPopup/', module)
storiesOf('Alerts/AlertPopup', module)
.addParameters({ options: { showPanel: false } })
.add(
`AlertPopup`,
Expand Down
2 changes: 1 addition & 1 deletion ui/stories/auth-config-form/config.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const MODELS = {

const DEFAULT_VALUE = 'aws/client';

storiesOf('AuthConfigForm/Config/', module)
storiesOf('AuthConfigForm/Config', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs())
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/stories/auth-config-form/options.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const MODELS = {

const DEFAULT_VALUE = 'aws/client';

storiesOf('AuthConfigForm/Options/', module)
storiesOf('AuthConfigForm/Options', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs())
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/stories/auth-form.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import hbs from 'htmlbars-inline-precompile';
import { storiesOf } from '@storybook/ember';
import notes from './auth-form.md';

storiesOf('AuthForm/', module)
storiesOf('AuthForm', module)
.addParameters({ options: { showPanel: false } })
.add(
`AuthForm`,
Expand Down
2 changes: 1 addition & 1 deletion ui/stories/file-to-array-buffer.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { withKnobs, text } from '@storybook/addon-knobs';

import notes from './file-to-array-buffer.md';

storiesOf('FileToArrayBuffer/', module)
storiesOf('FileToArrayBuffer', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(
withKnobs()
Expand Down
2 changes: 1 addition & 1 deletion ui/stories/http-requests-container.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const COUNTERS = [
{ start_time: '2019-03-01T00:00:00Z', total: 5000 },
];

storiesOf('HttpRequests/Container/', module)
storiesOf('HttpRequests/HttpRequestsContainer', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs())
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/stories/http-requests-table.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const COUNTERS = [
{ start_time: '2019-03-01T00:00:00Z', total: 5000 },
];

storiesOf('HttpRequests/Table/', module)
storiesOf('HttpRequests/Table', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs())
.add(
Expand Down
2 changes: 1 addition & 1 deletion ui/stories/toggle.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { storiesOf } from '@storybook/ember';
import notes from './toggle.md';
import { withKnobs, text, boolean, select } from '@storybook/addon-knobs';

storiesOf('Toggle/', module)
storiesOf('Toggle', module)
.addParameters({ options: { showPanel: true } })
.addDecorator(withKnobs())
.add(
Expand Down
Loading