Wrong highlighting for identifiers with dash

[orgads]

Server Version

0.25.2

Terraform Version

Terraform v1.1.5

Client Version

VS Code 1.64.0
Terraform extension v2.19.0

Terraform Configuration Files

foo/all.tf:

variable "foo" {}
output "result-val" { value = var.foo }

test.tf:

variable "some-var" {
  default = "value"
}

module "foo-mod" {
  source = "./foo"
  foo = var.some-var
}

module "bar" {
  source = "./foo"
  foo = module.foo-mod.result-val
}

Log Output

https://gist.github.com/orgads/ac0993b63aaca5601affd4dd7431e233

Expected Behavior

The identifiers that contain dash should be highlighted as identifiers.

Actual Behavior

They are only highlighted up to the dash, and the rest is white. Also the words "var" and "module" are not highlighted in this case.

After I run terraform init and reopen the file, highlighting is fixed. But if I reload the window, it is broken again until I reopen the file a few times.

In my project, the case is even worse. I can't get it to work, even after terraform init and reopening.

Steps to Reproduce

1. Create the 2 files in the description above.
2. Open the folder in VS Code
3. Open file test.tf from that folder
4. Trigger autocompletion on line 7, column 9 (1-indexed)
5. Trigger autocompletion on line 12, column 9 (1-indexed)

[dbanck]

Thanks a lot for the report and the excellent write-up. I can reproduce the issue.

We rely on TextMate grammars and semantic highlighting for syntax highlighting. TextMate grammars work on a single file as input and break it up based on lexical rules expressed in regular expressions. Highlighting based on semantic tokens is considered an addition to the TextMate-based syntax highlighting and goes on top of syntax highlighting. As language servers can take a while to load and analyze a project, semantic token highlighting may appear after a short delay.

We have improved the refresh of semantic tokens in hashicorp/terraform-ls#630, so we should highlight tokens faster now. And I'll raise a PR to address the bug in the grammar file soon.

[dbanck]

We've just merged #933 to address this issue.

This change will be released in the preview extension later this day if you would like to try this out. Furthermore, we will be releasing this to stable in the near future.

[orgads]

Thank you very much!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.