Enable Semantic Token Refresh #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpogran
force-pushed
the
semantic-token-refresh
branch
2 times, most recently
from
3ff2cf1 to
d6ad22c
Compare
jpogran
force-pushed
the
semantic-token-refresh
branch
from
d6ad22c to
dde334c
Compare
jpogran
force-pushed
the
semantic-token-refresh
branch
from
dde334c to
d4ef8a8
Compare
jpogran
force-pushed
the
semantic-token-refresh
branch
from
d4ef8a8 to
c73ed71
Compare
radeksimko
reviewed
Feb 3, 2022
jpogran
force-pushed
the
semantic-token-refresh
branch
2 times, most recently
from
0b38ab7 to
f7f3e7b
Compare
Add ModuleChangeHooks to trigger semantic token refresh when specified parts of the schema are discovered after initialization. Fixes #344
jpogran
force-pushed
the
semantic-token-refresh
branch
from
38d04b5 to
46b149d
Compare
radeksimko
approved these changes
Feb 8, 2022
There was a problem hiding this comment.
Thank you for bringing this over the finish line!
LGTM!
I'm not sure if this particular logic can trigger the bug but as a precaution I would perhaps hold on merging until creachadair/jrpc2#78 is addressed - hopefully very soon (creachadair/jrpc2#79).
|
The mentioned upstream bug was addressed in #787 Merge at will! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add change hooks to the Module state store to trigger token refresh after specified parts of the schema are discovered after initialization.
Fixes #344