Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement opt-in telemetry #681

Merged
merged 3 commits into from
Oct 26, 2021
Merged

Implement opt-in telemetry #681

merged 3 commits into from
Oct 26, 2021

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Oct 20, 2021

Documentation is attached and also linked from the main Readme.

For transparency I'll just paste example events here also:

{
    "v": 1,
    "name": "initialize",
    "properties": {
        "experimentalCapabilities.referenceCountCodeLens": true,
        "lsVersion": "0.23.0",
        "options.commandPrefix": true,
        "options.excludeModulePaths": false,
        "options.experimentalFeatures.prefillRequiredFields": false,
        "options.experimentalFeatures.validateOnSave": false,
        "options.rootModulePaths": false,
        "options.terraformExecPath": false,
        "options.terraformExecTimeout": "",
        "options.terraformLogFilePath": false,
        "root_uri": "dir"
    }
}
{
    "v": 1,
    "name": "moduleData",
    "properties": {
        "backend": "remote",
        "backend.remote.hostname": "app.terraform.io",
        "installedProviders": {
            "registry.terraform.io/hashicorp/aws": "3.57.0",
            "registry.terraform.io/hashicorp/null": "3.1.0"
        },
        "moduleId": "8aa5a4dc-4780-2d90-b8fb-57de8288fb32",
        "providerRequirements": {
            "registry.terraform.io/hashicorp/aws": "",
            "registry.terraform.io/hashicorp/null": "~> 3.1"
        },
        "tfRequirements": "~> 1.0",
        "tfVersion": "1.0.7"
    }
}

This PR also lays down the foundation of hooks that can be then reused in #630

@radeksimko radeksimko added the enhancement New feature or request label Oct 20, 2021
@radeksimko radeksimko force-pushed the f-telemetry branch 2 times, most recently from c72acdb to 5404afc Compare October 20, 2021 13:12
@radeksimko radeksimko marked this pull request as ready for review October 20, 2021 13:24
@radeksimko radeksimko requested a review from a team October 20, 2021 13:24
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor doc suggestions

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
internal/langserver/handlers/initialize.go Show resolved Hide resolved
radeksimko and others added 2 commits October 26, 2021 14:31
Co-authored-by: James Pogran <jpogran@outlook.com>
Co-authored-by: James Pogran <jpogran@outlook.com>
@radeksimko radeksimko merged commit 130111e into main Oct 26, 2021
@radeksimko radeksimko deleted the f-telemetry branch October 26, 2021 19:15
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants