Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process telemetry from language server #823

Merged
merged 3 commits into from
Nov 23, 2021
Merged

Process telemetry from language server #823

merged 3 commits into from
Nov 23, 2021

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Oct 20, 2021 •
edited
Loading

Depends on hashicorp/terraform-ls#681 but the release does not need to be coordinated. Older versions of LS will just ignore the experimental capability.

Regarding documentation, I believe the existing paragraph already reflects the existing situation which won't really change with this PR: https://github.com/hashicorp/vscode-terraform#telemetry

@radeksimko radeksimko added the enhancement New feature or request label Oct 20, 2021
@radeksimko radeksimko mentioned this pull request Oct 31, 2021
Closed
@radeksimko radeksimko force-pushed the f-telemetry branch 2 times, most recently from 1c8a760 to d993605 Compare November 11, 2021 19:13
@radeksimko radeksimko marked this pull request as ready for review November 11, 2021 19:27
@radeksimko radeksimko requested a review from a team November 11, 2021 19:27
dbanck
dbanck reviewed Nov 16, 2021
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few suggestions for now and want to dig into disposables for a bit

src/telemetry.ts Outdated Show resolved Hide resolved
src/telemetry.ts Show resolved Hide resolved
src/telemetry.ts Outdated Show resolved Hide resolved
jpogran
jpogran approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your research is spot on that there isn't a clear way to implement this outside of StaticFeature. I think this is good to go for now and if something crops up later we'll address then

@radeksimko radeksimko requested a review from dbanck November 23, 2021 16:22
@radeksimko radeksimko merged commit cdaff10 into main Nov 23, 2021
@radeksimko radeksimko deleted the f-telemetry branch November 23, 2021 17:26
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpogran jpogran jpogran approved these changes

@dbanck dbanck dbanck approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radeksimko @dbanck @jpogran