This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Fix overwriting default project model #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregone
force-pushed
the
ui/bugfix-leaky-settings
branch
from
d8ffa06
to
a5b4bcc
Compare
jgwhite
approved these changes
Sep 8, 2021
|
Do we need to backport this? |
|
Should this issue be linked to this PR? #2150
I think so yes! 🤔 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2150
populateExistingFieldswas mutating theDEFAULT_PROJECT_MODELproperties, thus causing the values to be retained when the component was reused.This PR sets the
defaultProjecton the component as a static property, and then reads keys from that object inpopulateExistingFields.